Propagate backlinks on Signal and Signal-with-Start responses#9897
Open
long-nt-tran wants to merge 1 commit intotemporalio:mainfrom
Open
Propagate backlinks on Signal and Signal-with-Start responses#9897long-nt-tran wants to merge 1 commit intotemporalio:mainfrom
long-nt-tran wants to merge 1 commit intotemporalio:mainfrom
Conversation
long-nt-tran
commented
Apr 9, 2026
550bf51 to
589224e
Compare
589224e to
4c69cc2
Compare
long-nt-tran
commented
Apr 10, 2026
Comment on lines
+219
to
+220
|
|
||
| replace go.temporal.io/api => github.com/long-nt-tran/api-go v0.0.0-20260410154440-a741268f8bab |
Contributor
Author
There was a problem hiding this comment.
only pointing to my fork for CI tests, will wait for temporalio/api#761 and subsequent api-go codegen to be merged and then remove these before I merge this PR
bergundy
reviewed
Apr 10, 2026
Member
bergundy
left a comment
There was a problem hiding this comment.
Here's what's missing:
- Adding to the map that tracks request ID to event ID
- A functional test that verifies that request IDs for all of these requests are added to the map
- Ensure that the workflow start link is only populated if an execution was started
Member
There was a problem hiding this comment.
A test that's all mocked out doesn't provide a ton of value IMHO. Just test this with functional tests in the tests/ directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
With these PRs to add the
linkfield on these responses protobufs:This PR adds logic from the server that does the following:
linkon signal and signal-with-start responses andmake protosignalworkflowandsignalwithstartworkflowto propagate the link from request back to the history responselink_util.goNote
From discussion w/ @Quinn-With-Two-Ns since signals are buffered, the link is generated with a reference to the
RequestIdrather thanEventId.Why?
This will enable the caller of the signal to have a backlink to the cross-namespace signal invoked, which will become more relevant for Nexus SDK ergonomics.
How did you test it?
Unit tests
Functional tests
Potential risks
Need to test end-to-end to see that the link shows up correctly in the Web UI.