Go codegen for propagating backlink for signal and signal-with-start#247
Closed
long-nt-tran wants to merge 1 commit intotemporalio:masterfrom
Closed
Go codegen for propagating backlink for signal and signal-with-start#247long-nt-tran wants to merge 1 commit intotemporalio:masterfrom
long-nt-tran wants to merge 1 commit intotemporalio:masterfrom
Conversation
|
|
long-nt-tran
force-pushed
the
signals-backlink-api-gen
branch
3 times, most recently
from
f76dee0 to
0aab045
Compare
Contributor
|
Oh NVM maybe I am wrong there I see other people have, I thought it was automated |
5 tasks
long-nt-tran
force-pushed
the
signals-backlink-api-gen
branch
from
0aab045 to
a741268
Compare
Author
seems like it is automated (spoke w/ Stephan offline), I'll close this PR for now and let the machinery do its thing once the API PR temporalio/api#761 closes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Codegen of temporalio/api#761 by running
make update-protowithproto/apisubmodule pointed at that PR's branch.Why?
As titled.
How did you test it?
Server PR has integration tests: temporalio/temporal#9897
Potential risks
N/A, unused field