Skip to content

fix: update DataStore for 16 KB compatibility - #1107

Merged
ovitrif merged 1 commit into
masterfrom
ovi/fix-16kb-dependencies
Jul 28, 2026
Merged

fix: update DataStore for 16 KB compatibility#1107
ovitrif merged 1 commit into
masterfrom
ovi/fix-16kb-dependencies

Conversation

@ovitrif

@ovitrif ovitrif commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Fixes #1103

This PR:

  1. Updates AndroidX DataStore to 1.2.1 so libdatastore_shared_counter.so uses 16 KB-aligned GNU_RELRO padding.
  2. Leaves every other native dependency version and the existing native packaging and release paths unchanged.
  3. Clears the complete Android compatibility alert in a clean Android 17/API 37 installation with PAGE_SIZE=16384; the captured runtime result reports pageSizeCompat=0.

QA Notes

Manual Tests

  • Fresh-install mainnetDebug on the Android 17 Pixel_10_Pro_XL emulator with a 16 KB page size → Confirm the Android compatibility alert is absent and pageSizeCompat=0.

Automated Checks

  • just compile
  • just test
  • just lint
  • just changelog next
  • Remote-only :app:assembleMainnetDebug --refresh-dependencies with Maven Local excluded
  • git diff --check

@ovitrif
ovitrif marked this pull request as ready for review July 24, 2026 08:30
@greptile-apps

This comment has been minimized.

greptile-apps[bot]

This comment was marked as resolved.

coreyphillips

This comment was marked as resolved.

@ovitrif ovitrif self-assigned this Jul 25, 2026
@ovitrif
ovitrif force-pushed the ovi/fix-16kb-dependencies branch from c0eb7ec to f9b61c1 Compare July 25, 2026 15:48
@ovitrif ovitrif changed the title fix: support 16 KB Android pages fix: update DataStore for 16 KB compatibility Jul 25, 2026
@ovitrif

ovitrif commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator Author

@coreyphillips Thanks — your review identified the problem. The verification script and 49k-line vendored rewrite were an overengineered, bad AI attempt. I removed them completely.

This PR now contains only the DataStore 1.2.0 → 1.2.1 update and its changelog fragment: 2 insertions and 1 deletion. The original Android 17 alert named libdatastore_shared_counter.so and reported its GNU_RELRO segment as unaligned. Focused llvm-readelf inspection shows the official 1.2.1 binary moves the GNU_RELRO end from 0xd000 to the 16 KB boundary at 0xc000.

I then built mainnetDebug from remote dependencies and performed a fresh uninstall/install on a clean Android 17 Pixel 10 Pro XL 16 KB emulator. The app reaches the Terms screen without the compatibility alert and reports pageSizeCompat=0.

Bundled ML Kit remains unchanged. The scanner code, native verification scripts, symbol packaging, and NativeReleaseConfigTest are unchanged from master. Against #1106, gradle/libs.versions.toml auto-merges; the only merge-tree conflict is LightningService.kt, and the same conflict already exists between current master and #1106.

Could you re-review the reduced head f9b61c149?

@ovitrif
ovitrif requested a review from coreyphillips July 25, 2026 15:55
@ovitrif
ovitrif removed the request for review from ben-kaufman July 27, 2026 13:44
@ovitrif
ovitrif force-pushed the ovi/fix-16kb-dependencies branch from f9b61c1 to ad4f97e Compare July 27, 2026 14:01
@ovitrif
ovitrif enabled auto-merge July 27, 2026 14:01

@jvsena42 jvsena42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on Pixel 9 Android 17 / API 37, PAGE_SIZE=16384 (16 KB pages) emulator

@ovitrif
ovitrif merged commit b7e3f12 into master Jul 28, 2026
18 checks passed
@ovitrif
ovitrif deleted the ovi/fix-16kb-dependencies branch July 28, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: update DataStore for 16 KB compatibility

3 participants