Skip to content

fix: integrate android elf build-id releases - #1106

Open
ovitrif wants to merge 9 commits into
masterfrom
ovi/fix-native-symbol-build-ids
Open

fix: integrate android elf build-id releases#1106
ovitrif wants to merge 9 commits into
masterfrom
ovi/fix-native-symbol-build-ids

Conversation

@ovitrif

@ovitrif ovitrif commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Fixes #1104

This PR completes the Bitkit Android consumer portion of #1105.

Companion PRs:

Description

This PR:

  1. Adds Paykit to Bitkit Android's existing native debug-symbol archive and requires libpaykit.so for both release ABIs.
  2. Adopts the four compatible Android package releases:
    • LDK 0.7.0-rc.58
    • bitkit-core 0.5.3
    • VSS 0.5.21
    • Paykit 0.1.0-rc40
  3. Supplies LDK's required Electrum full-scan defaults.
  4. Adapts the Paykit integration to rc40's public/private payment API split, persisted receiver Noise key, and payment-list freshness version.

bitkit-core 0.5.3 carries synonymdev/bitkit-core#131 on the Boltz-capable release line used by current Bitkit Android master.

Release

Preview

N/A — dependency and release-artifact integration only.

QA Notes

Manual Tests

N/A

Automated Checks

  • Local verification against the four hosted producer releases: just compile, just test, and just lint
  • PaykitSdkServiceTest.kt, PrivatePaykitRepoTest.kt, and AppViewModelSendFlowTest.kt: cover rc40 sessions, public/private fallback, and payment-list consumption before on-chain, BOLT11, and LNURL sends
  • NativeReleaseConfigTest.kt: covers Paykit symbol dependency wiring and required native libraries
  • Native release integration: clean hosted resolution plus scripts/create-native-debug-symbols.sh
  • Archive result: native-debug-symbols-187.zip contains all four required libraries for arm64-v8a and armeabi-v7a

@greptile-apps

This comment was marked as outdated.

coreyphillips

This comment was marked as outdated.

@ovitrif
ovitrif force-pushed the ovi/fix-native-symbol-build-ids branch from 03758ad to fe83b1e Compare July 25, 2026 16:12
@ovitrif
ovitrif requested a review from coreyphillips July 25, 2026 16:13
@ovitrif

This comment was marked as outdated.

@ovitrif
ovitrif force-pushed the ovi/fix-native-symbol-build-ids branch from fe83b1e to c67ef8b Compare July 25, 2026 18:15
@ovitrif
ovitrif requested review from ben-kaufman and coreyphillips and removed request for ben-kaufman and coreyphillips July 25, 2026 18:17
@ovitrif

This comment was marked as outdated.

@ovitrif ovitrif closed this Jul 25, 2026
@ovitrif ovitrif reopened this Jul 25, 2026
@ovitrif
ovitrif force-pushed the ovi/fix-native-symbol-build-ids branch from c67ef8b to 3ee6b13 Compare July 26, 2026 16:56
@ovitrif ovitrif changed the title fix: verify native release build ids fix: include paykit native symbols Jul 26, 2026
@ovitrif

This comment was marked as outdated.

@ovitrif ovitrif self-assigned this Jul 27, 2026
@ovitrif
ovitrif removed the request for review from ben-kaufman July 27, 2026 13:46
@ovitrif ovitrif changed the title fix: include paykit native symbols fix: integrate android elf build-id releases Jul 27, 2026
@ovitrif
ovitrif force-pushed the ovi/fix-native-symbol-build-ids branch from 075f03a to e0e32b3 Compare July 28, 2026 17:34
@ovitrif
ovitrif requested a review from jvsena42 July 28, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: adopt Android ELF build-ID releases

2 participants