Skip to content

test: align test models with null-marked defaults #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zantvoort merged 1 commit into from
Jul 14, 2026
Merged

test: align test models with null-marked defaults #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions storm-h2/src/test/java/st/orm/spi/h2/H2SchemaValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,19 @@ public class H2SchemaValidatorTest {

public record Vet(
@PK Integer id,
String firstName,
String lastName
@Nullable String firstName,
@Nullable String lastName
) implements Entity<Integer> {}

public record Address(
String address,
String city
@Nullable String address,
@Nullable String city
) {}

public record Owner(
@PK Integer id,
String firstName,
String lastName,
@Nullable String firstName,
@Nullable String lastName,
Address address,
@Nullable String telephone,
@Nullable Integer version
Expand Down
12 changes: 6 additions & 6 deletions storm-mariadb/src/test/java/st/orm/spi/mariadb/MariaDBSchemaValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,19 +74,19 @@ static void overrideProperties(DynamicPropertyRegistry registry) {

public record Vet(
@PK Integer id,
String firstName,
String lastName
@Nullable String firstName,
@Nullable String lastName
) implements Entity<Integer> {}

public record Address(
String address,
String city
@Nullable String address,
@Nullable String city
) {}

public record Owner(
@PK Integer id,
String firstName,
String lastName,
@Nullable String firstName,
@Nullable String lastName,
Address address,
@Nullable String telephone,
@Nullable Integer version
Expand Down
12 changes: 6 additions & 6 deletions storm-mssqlserver/src/test/java/st/orm/spi/mssqlserver/MSSQLServerSchemaValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,19 +74,19 @@ static void overrideProperties(DynamicPropertyRegistry registry) {

public record Vet(
@PK Integer id,
String firstName,
String lastName
@Nullable String firstName,
@Nullable String lastName
) implements Entity<Integer> {}

public record Address(
String address,
String city
@Nullable String address,
@Nullable String city
) {}

public record Owner(
@PK Integer id,
String firstName,
String lastName,
@Nullable String firstName,
@Nullable String lastName,
Address address,
@Nullable String telephone,
@Nullable Integer version
Expand Down
12 changes: 6 additions & 6 deletions storm-mysql/src/test/java/st/orm/spi/mysql/MySQLSchemaValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,19 +73,19 @@ static void overrideProperties(DynamicPropertyRegistry registry) {

public record Vet(
@PK Integer id,
String firstName,
String lastName
@Nullable String firstName,
@Nullable String lastName
) implements Entity<Integer> {}

public record Address(
String address,
String city
@Nullable String address,
@Nullable String city
) {}

public record Owner(
@PK Integer id,
String firstName,
String lastName,
@Nullable String firstName,
@Nullable String lastName,
Address address,
@Nullable String telephone,
@Nullable Integer version
Expand Down
12 changes: 6 additions & 6 deletions storm-oracle/src/test/java/st/orm/spi/oracle/OracleSchemaValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,19 +87,19 @@ static void overrideProperties(DynamicPropertyRegistry registry) {

public record Vet(
@PK Integer id,
String firstName,
String lastName
@Nullable String firstName,
@Nullable String lastName
) implements Entity<Integer> {}

public record Address(
String address,
String city
@Nullable String address,
@Nullable String city
) {}

public record Owner(
@PK Integer id,
String firstName,
String lastName,
@Nullable String firstName,
@Nullable String lastName,
Address address,
@Nullable String telephone,
@Nullable Integer version
Expand Down
12 changes: 6 additions & 6 deletions storm-postgresql/src/test/java/st/orm/spi/postgresql/PostgreSQLSchemaValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,19 +74,19 @@ static void overrideProperties(DynamicPropertyRegistry registry) {

public record Vet(
@PK Integer id,
String firstName,
String lastName
@Nullable String firstName,
@Nullable String lastName
) implements Entity<Integer> {}

public record Address(
String address,
String city
@Nullable String address,
@Nullable String city
) {}

public record Owner(
@PK Integer id,
String firstName,
String lastName,
@Nullable String firstName,
@Nullable String lastName,
Address address,
@Nullable String telephone,
@Nullable Integer version
Expand Down
5 changes: 3 additions & 2 deletions storm-spring/src/test/java/st/orm/spring/SpringTransactionBridgeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import static st.orm.template.Transactions.transaction;

import java.io.IOException;
import java.time.Instant;
import java.time.LocalDate;
import java.util.List;
import javax.sql.DataSource;
Expand Down Expand Up @@ -69,7 +70,7 @@ void setUp() {
}

private void insertVisit(String description) {
visits.insert(new Visit(null, LocalDate.now(), description, pet, null));
visits.insert(new Visit(null, LocalDate.now(), description, pet, Instant.now()));
}

@Test
Expand Down Expand Up @@ -156,7 +157,7 @@ void providerWithoutManagersRejectsStormInitiatedTransactions() {
EntityRepository<Visit, Integer> unbridgedVisits = unbridged.entity(Visit.class);
PersistenceException exception = assertThrows(PersistenceException.class, () ->
transaction(tx -> {
unbridgedVisits.insert(new Visit(null, LocalDate.now(), "never", pet, null));
unbridgedVisits.insert(new Visit(null, LocalDate.now(), "never", pet, Instant.now()));
return null;
}));
assertTrue(exception.getMessage().contains("PlatformTransactionManager supplier"));
Expand Down
12 changes: 6 additions & 6 deletions storm-sqlite/src/test/java/st/orm/spi/sqlite/SQLiteSchemaValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,19 @@ public class SQLiteSchemaValidatorTest {

public record Vet(
@PK Integer id,
String firstName,
String lastName
@Nullable String firstName,
@Nullable String lastName
) implements Entity<Integer> {}

public record Address(
String address,
String city
@Nullable String address,
@Nullable String city
) {}

public record Owner(
@PK Integer id,
String firstName,
String lastName,
@Nullable String firstName,
@Nullable String lastName,
Address address,
@Nullable String telephone,
@Nullable Integer version
Expand Down
Loading