test: align test models with null-marked defaults#258
Merged
Conversation
Following #257 (null-marked models by default), record components that were implicitly nullable now require explicit @nullable. Annotate the Vet, Address, and Owner records in the H2/MariaDB/MySQL/MSSQLServer/Oracle/PostgreSQL/SQLite schema validator tests, and pass a non-null Instant for Visit inserts in the Spring transaction bridge test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #257 (null-marked models by default). Now that record components are
non-null unless annotated, several test models that relied on implicit nullability
no longer compile/validate as intended. This aligns them with the new contract.
Changes
firstName/lastNameonVetandOwner, andaddress/cityonAddress, with@Nullablein the schema validator tests for H2, MariaDB, MySQL,MSSQLServer, Oracle, PostgreSQL, and SQLite.
Instant.now()(instead ofnull) for theVisittimestamp inSpringTransactionBridgeTest.Test-only; no production code affected.