Skip to content

chore: add isNumber assertion in plot/vega/axis/ctor/lib/band-position #10780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Planeshifter merged 1 commit into from
Mar 7, 2026
+2 −1
Merged

chore: add isNumber assertion in plot/vega/axis/ctor/lib/band-position #10780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/node_modules/@stdlib/plot/vega/axis/ctor/lib/band-position/set.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
var logger = require( 'debug' );
var isUndefined = require( '@stdlib/assert/is-undefined' );
var isBetween = require( '@stdlib/assert/is-between' );
var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
var format = require( '@stdlib/string/format' );
var changeEvent = require( './../change_event.js' );
var prop = require( './properties.js' );
Expand All @@ -42,7 +43,7 @@
*
* ## Notes
*
* - Providing `undefined` "unsets" the configured value.

Check warning on line 46 in lib/node_modules/@stdlib/plot/vega/axis/ctor/lib/band-position/set.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "unsets"
*
* @private
* @param {(number|void)} value - input value
Expand All @@ -50,7 +51,7 @@
* @returns {void}
*/
function set( value ) {
if ( !isBetween( value, 0.0, 1.0 ) && !isUndefined( value ) ) {
if ( !( isNumber( value ) && isBetween( value, 0.0, 1.0 ) ) && !isUndefined( value ) ) {

Check warning on line 54 in lib/node_modules/@stdlib/plot/vega/axis/ctor/lib/band-position/set.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

This line has a length of 92. Maximum allowed is 80
throw new TypeError( format( 'invalid assignment. `%s` must be on the interval: [0, 1]. Value: `%s`.', prop.name, value ) );
}
if ( value !== this[ prop.private ] ) {
Expand Down
Loading