Skip to content

chore: add isNumber assertion in plot/vega/axis/ctor/lib/band-position#10780

Merged
Planeshifter merged 1 commit intostdlib-js:refactor/plotfrom
Sachinn-64:fix-band_position.js
Mar 7, 2026
Merged

chore: add isNumber assertion in plot/vega/axis/ctor/lib/band-position#10780
Planeshifter merged 1 commit intostdlib-js:refactor/plotfrom
Sachinn-64:fix-band_position.js

Conversation

@Sachinn-64
Copy link
Member

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • chore: add isNumber assertion in plot/vega/axis/ctor/lib/band-position

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 6, 2026
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 7, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 7, 2026
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: add isNumber assertion in `plot/vega/axis/ctor/lib/band-position`

PR-URL: https://github.com/stdlib-js/stdlib/pull/10780

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit fb8a93b into stdlib-js:refactor/plot Mar 7, 2026
48 of 49 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants