Skip to content

Fix RangeError when all SH arrays are present #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marwie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix RangeError when all SH arrays are present #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/SplatPager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,7 +1170,10 @@ export class SplatPager {
data.extra.sh3a as Uint32Array,
data.extra.sh3b as Uint32Array,
];
shArrays.length = shArrays.findIndex((sh) => !sh);
// findIndex returns -1 when all SH arrays are present — keep the full list
// (Array.length = -1 throws a RangeError)
const firstMissingSh = shArrays.findIndex((sh) => !sh);
if (firstMissingSh >= 0) shArrays.length = firstMissingSh;
this.newUploads.push({
page,
numSplats,
Expand All @@ -1185,7 +1188,10 @@ export class SplatPager {
data.extra.sh2 as Uint32Array,
data.extra.sh3 as Uint32Array,
];
shArrays.length = shArrays.findIndex((sh) => !sh);
// findIndex returns -1 when all SH arrays are present — keep the full list
// (Array.length = -1 throws a RangeError)
const firstMissingSh = shArrays.findIndex((sh) => !sh);
if (firstMissingSh >= 0) shArrays.length = firstMissingSh;
this.newUploads.push({
page,
numSplats,
Expand Down