Fix RangeError when all SH arrays are present - #404
Open
marwie wants to merge 1 commit into
Open
Conversation
shArrays.length = findIndex(...) sets the length to -1 when no entry is missing (all SH bands resident, e.g. maxSh 3), which throws 'Invalid array length'. Only truncate when a missing entry exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SplatPagertruncates the SH upload list withfindIndexreturns-1when no entry is missing — i.e. whenever a chunk has all SH bands (the normal case atmaxSh: 3) — and settingArray.length = -1throwsRangeError: Invalid array length. On currentmainthis breaks paged loading of any file with full SH data (not present in the released 2.1.0).Fix: only truncate when a missing entry exists (both sites).
Repro: load a paged
.radwith SH bands at defaultmaxSh— the first chunk upload throws.