MPT-19488 merge chat message fixtures and unskip link tests#269
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughConsolidates chat-message fixtures into the parent chats conftest, deletes the messages subdirectory conftest, adds/rewires sync/async chat message and link fixtures, unskips several chat-link E2E tests, and reformats/adjusts entries in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/e2e/helpdesk/chats/links/conftest.py`:
- Around line 35-37: The fixture created_chat_link_service yields a scoped
service using a nullable chain chat_link.to_dict().get("chat", {}).get("id")
which can produce None; instead use the concrete chat id available on the
created resource (from chat_link or the resource returned by
create_fixture_resource_and_delete) or yield the already-scoped service used to
create the link to avoid nullable extraction. Update created_chat_link_service
to obtain the chat id directly from the created resource (e.g.
chat_link.chat["id"] or the resource's direct attribute/method) or yield the
existing scoped service, and apply the same change to the other similar fixture
referenced in the comment (the one around lines 49-53).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: aaa4db91-8b27-43e9-87b1-a6cea46c11c1
📒 Files selected for processing (6)
pyproject.tomltests/e2e/helpdesk/chats/conftest.pytests/e2e/helpdesk/chats/links/conftest.pytests/e2e/helpdesk/chats/links/test_async_links.pytests/e2e/helpdesk/chats/links/test_sync_links.pytests/e2e/helpdesk/chats/messages/conftest.py
💤 Files with no reviewable changes (1)
- tests/e2e/helpdesk/chats/messages/conftest.py
jentyk
force-pushed
the
feat/MPT-19488
branch
2 times, most recently
from
a65ea6d to
ad9603f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/e2e/helpdesk/chats/links/test_sync_links.py`:
- Line 18: The test function declaration test_create_chat_link (in
tests/e2e/helpdesk/chats/links/test_sync_links.py) contains an invalid noqa
marker "# noqa: AAA01"; remove that invalid noqa (or replace it with a valid
three-digit AAA code like "AAA001" if you intended to suppress a specific rule)
so Ruff no longer raises RUF102 and normal linting applies to the test function.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 8159e94e-86de-42fd-8db9-f5591c6b7fe8
📒 Files selected for processing (6)
pyproject.tomltests/e2e/helpdesk/chats/conftest.pytests/e2e/helpdesk/chats/links/conftest.pytests/e2e/helpdesk/chats/links/test_async_links.pytests/e2e/helpdesk/chats/links/test_sync_links.pytests/e2e/helpdesk/chats/messages/conftest.py
💤 Files with no reviewable changes (1)
- tests/e2e/helpdesk/chats/messages/conftest.py
🚧 Files skipped from review as they are similar to previous changes (2)
- pyproject.toml
- tests/e2e/helpdesk/chats/links/conftest.py
|
albertsola
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes MPT-19488