Skip to content

MPT-19487 unskip chat message tests by removing skip markers#270

Merged
jentyk merged 1 commit intomainfrom
feat/MPT-19487
Apr 2, 2026
Merged

MPT-19487 unskip chat message tests by removing skip markers#270
jentyk merged 1 commit intomainfrom
feat/MPT-19487

Conversation

@jentyk
Copy link
Copy Markdown
Member

@jentyk jentyk commented Apr 2, 2026

Closes MPT-19487

  • Removed @pytest.mark.skip decorators from chat message tests in both test_async_messages.py and test_sync_messages.py
  • Re-enabled three previously skipped tests: test_create_chat_message, test_update_chat_message_visibility, and test_delete_chat_message
  • Tests are now active for execution following completion of MPT-19124

@jentyk jentyk requested a review from a team as a code owner April 2, 2026 10:10
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 03128860-8f7a-41ac-8a51-0b387831b22c

📥 Commits

Reviewing files that changed from the base of the PR and between 82dc28b and bf16db9.

📒 Files selected for processing (2)
  • tests/e2e/helpdesk/chats/messages/test_async_messages.py
  • tests/e2e/helpdesk/chats/messages/test_sync_messages.py

📝 Walkthrough

Walkthrough

This PR removes @pytest.mark.skip decorators from three chat message tests across async and sync test files. The decorators included a reference to ticket MPT-19124. No changes to test logic, assertions, or function signatures were made.

Changes

Cohort / File(s) Summary
Chat message test unskipping
tests/e2e/helpdesk/chats/messages/test_async_messages.py, tests/e2e/helpdesk/chats/messages/test_sync_messages.py
Removed @pytest.mark.skip(...) decorators from test_create_chat_message, test_update_chat_message_visibility, and test_delete_chat_message in both files, enabling these three tests to run.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key MPT-19487 in the required MPT-XXXX format at the beginning.
Test Coverage Required ✅ Passed The PR modifies code files in mpt_api_client/ directory and includes changes in tests/ folder, satisfying the pass condition.
Single Commit Required ✅ Passed The PR contains exactly one commit titled 'test(helpdesk): unskip chat message tests by removing skip markers' (commit hash bf16db9).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

@jentyk jentyk merged commit af7862f into main Apr 2, 2026
4 checks passed
@jentyk jentyk deleted the feat/MPT-19487 branch April 2, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants