You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewing files that changed from the base of the PR and between 72e9a02 and 14aee1b.
📒 Files selected for processing (1)
tests/e2e/conftest.py
📝 Walkthrough
Walkthrough
Seven pytest fixtures in tests/e2e/conftest.py (mpt_vendor, async_mpt_vendor, mpt_ops, async_mpt_ops, mpt_client, async_mpt_client, and rp_logger) have their scope changed from "session" to "module". No fixture logic was modified; only the decorator scope parameter was updated.
Changed 7 fixtures from session-scoped to module-scoped: mpt_vendor, async_mpt_vendor, mpt_ops, async_mpt_ops, mpt_client, async_mpt_client, and rp_logger. Fixtures are now instantiated once per test module instead of once per test session.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
MPT-19124 speed up tests #262: Modifies the same pytest fixtures in tests/e2e/conftest.py with identical scope changes from session to module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes MPT-19124
Changed pytest fixture scope from
sessiontomodulefor seven fixtures intests/e2e/conftest.py:mpt_vendorasync_mpt_vendormpt_opsasync_mpt_opsmpt_clientasync_mpt_clientrp_loggerFixtures now have a module-level lifetime, meaning they are created once per test module instead of once per entire test session