Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ const AudioVisualizer: React.FC = () => {
bufferSourceRef.current = audioContextRef.current.createBufferSource();
bufferSourceRef.current.buffer = audioBuffer;
bufferSourceRef.current.connect(analyserRef.current);
bufferSourceRef.current.connect(audioContextRef.current.destination);

const when = audioContextRef.current.currentTime;
setStartTime(when);
Expand Down Expand Up @@ -84,7 +85,6 @@ const AudioVisualizer: React.FC = () => {
fftSize: FFT_SIZE,
smoothingTimeConstant: 0.2,
});
analyserRef.current.connect(audioContextRef.current.destination);
}

fetchAudioBuffer();
Expand Down
26 changes: 13 additions & 13 deletions apps/fabric-example/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1842,7 +1842,7 @@ PODS:
- React-utils (= 0.85.0)
- ReactNativeDependencies
- ReactNativeDependencies (0.85.0)
- RNAudioAPI (0.13.0):
- RNAudioAPI (1.0.0):
- hermes-engine
- RCTRequired
- RCTTypeSafety
Expand All @@ -1863,10 +1863,10 @@ PODS:
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- ReactNativeDependencies
- RNAudioAPI/audioapi (= 0.13.0)
- RNAudioAPI/audioapi (= 1.0.0)
- RNWorklets
- Yoga
- RNAudioAPI/audioapi (0.13.0):
- RNAudioAPI/audioapi (1.0.0):
- hermes-engine
- RCTRequired
- RCTTypeSafety
Expand All @@ -1887,12 +1887,12 @@ PODS:
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- ReactNativeDependencies
- RNAudioAPI/audioapi/audioapi_dsp (= 0.13.0)
- RNAudioAPI/audioapi/ios (= 0.13.0)
- RNAudioAPI/audioapi/miniaudio_impl (= 0.13.0)
- RNAudioAPI/audioapi/audioapi_dsp (= 1.0.0)
- RNAudioAPI/audioapi/ios (= 1.0.0)
- RNAudioAPI/audioapi/miniaudio_impl (= 1.0.0)
- RNWorklets
- Yoga
- RNAudioAPI/audioapi/audioapi_dsp (0.13.0):
- RNAudioAPI/audioapi/audioapi_dsp (1.0.0):
- hermes-engine
- RCTRequired
- RCTTypeSafety
Expand All @@ -1915,7 +1915,7 @@ PODS:
- ReactNativeDependencies
- RNWorklets
- Yoga
- RNAudioAPI/audioapi/ios (0.13.0):
- RNAudioAPI/audioapi/ios (1.0.0):
- hermes-engine
- RCTRequired
- RCTTypeSafety
Expand All @@ -1938,7 +1938,7 @@ PODS:
- ReactNativeDependencies
- RNWorklets
- Yoga
- RNAudioAPI/audioapi/miniaudio_impl (0.13.0):
- RNAudioAPI/audioapi/miniaudio_impl (1.0.0):
- hermes-engine
- RCTRequired
- RCTTypeSafety
Expand Down Expand Up @@ -2476,7 +2476,7 @@ EXTERNAL SOURCES:

SPEC CHECKSUMS:
FBLazyVector: c00c20551d40126351a6783c47ce75f5b374851b
hermes-engine: 91023181d4bc5948b457de5314623fbfe4f8604e
hermes-engine: c399a2e224a0b13c589d76b4fc05e14bdd76fa88
RCTDeprecation: 3bb167081b134461cfeb875ff7ae1945f8635257
RCTRequired: 74839f55d5058a133a0bc4569b0afec750957f64
RCTSwiftUI: 87a316382f3eab4dd13d2a0d0fd2adcce917361a
Expand All @@ -2485,7 +2485,7 @@ SPEC CHECKSUMS:
React: 1b1536b9099195944034e65b1830f463caaa8390
React-callinvoker: 6dff6d17d1d6cc8fdf85468a649bafed473c65f5
React-Core: 00faa4d038298089a1d5a5b21dde8660c4f0820d
React-Core-prebuilt: a6d614de037caff7898424dfc22915ec792de921
React-Core-prebuilt: ab26be1216323aea7c76f96ca450bffa7bcd4a72
React-CoreModules: a17807f849bfd86045b0b9a75ec8c19373b482f6
React-cxxreact: c7b53ace5827be54048288bce5c55f337c41e95f
React-debug: e1f00fcd2cef58a2897471a6d76a4ef5f5f90c74
Expand Down Expand Up @@ -2549,8 +2549,8 @@ SPEC CHECKSUMS:
ReactAppDependencyProvider: 5787b37b8e2e51dfeab697ec031cc7c4080dcea2
ReactCodegen: d07ee3c8db75b43d1cbe479ae6affebf9925c733
ReactCommon: fe2a3af8975e63efa60f95fca8c34dc85deee360
ReactNativeDependencies: 4d5ce2683b6d74f7c686bf90a88c7d381295cf3c
RNAudioAPI: b689aba6e8b4e6ac85b7e4eb53ebb74a020fbed4
ReactNativeDependencies: 212738cc51e6c4cc34ee487890497d6f41979ec0
RNAudioAPI: 6b07e5393a8016de35ba8d2f8b010ce2d7e0c3fd
RNGestureHandler: 187c5c7936abf427bc4d22d6c3b1ac80ad1f63c0
RNReanimated: 64f4b3b33b48b19e0ba76a352571b52b1e931981
RNScreens: 01b065ded2dfe7987bcce770ff3a196be417ff41
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,24 @@ class AudioNode : public utils::graph::GraphObject, public std::enable_shared_fr
audioBuffer_ = buffer;
}

/// @brief Buffer whose channel layout is negotiated from upstream connections.
/// Default: same as the output buffer. StereoPanner negotiates the input
/// buffer while keeping a fixed stereo output.
[[nodiscard]] virtual std::shared_ptr<DSPAudioBuffer> getNegotiatedBuffer() const {
return getOutputBuffer();
}

virtual void setNegotiatedBuffer(const std::shared_ptr<DSPAudioBuffer> &buffer) {
setOutputBuffer(buffer);
}

/// @brief Channel count this node presents on upstream connections (toward
/// AudioDestinationNode) after negotiation. Default: the negotiated channel
/// count. StereoPanner always outputs stereo.
[[nodiscard]] virtual size_t getUpstreamChannelCount(size_t negotiatedChannelCount) const {
return negotiatedChannelCount;
}

/// @note JS Thread only
[[nodiscard]] bool requiresTailProcessing() const;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,18 @@ std::shared_ptr<DSPAudioBuffer> StereoPannerNode::getOutputBuffer() const {
return outputBuffer_;
}

std::shared_ptr<DSPAudioBuffer> StereoPannerNode::getNegotiatedBuffer() const {
return getInputBuffer();
}

void StereoPannerNode::setNegotiatedBuffer(const std::shared_ptr<DSPAudioBuffer> &buffer) {
audioBuffer_ = buffer;
}

size_t StereoPannerNode::getUpstreamChannelCount(size_t /*negotiatedChannelCount*/) const {
return outputBuffer_->getNumberOfChannels();
}

void StereoPannerNode::processNode(int framesToProcess) {
std::shared_ptr<BaseAudioContext> context = context_.lock();
if (context == nullptr) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ class StereoPannerNode : public AudioNode {

[[nodiscard]] std::shared_ptr<AudioParam> getPanParam() const;
[[nodiscard]] std::shared_ptr<DSPAudioBuffer> getOutputBuffer() const override;
[[nodiscard]] std::shared_ptr<DSPAudioBuffer> getNegotiatedBuffer() const override;
void setNegotiatedBuffer(const std::shared_ptr<DSPAudioBuffer> &buffer) override;
[[nodiscard]] size_t getUpstreamChannelCount(size_t negotiatedChannelCount) const override;

protected:
void processNode(int framesToProcess) override;
Expand Down
Loading
Loading