fix: fixed channel count negotiations algorithm#1145
Open
maciejmakowski2003 wants to merge 2 commits into
Open
fix: fixed channel count negotiations algorithm#1145maciejmakowski2003 wants to merge 2 commits into
maciejmakowski2003 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RNAA-351
Introduced changes
Fixed a batch of issues related to channel count negotiations.
Issue 1 - default channel count instead of computed channel count.
Let's assume below graph structure and given order of connections:
source (1ch) -> gain1 (2ch) -> gain2 (2ch)
source -> gain1: gain1 buffer correctly becomes 1ch
gain1 -> gain2: gain2 reads gain1 output buffer as 2ch so it becomes 2ch that is incorrect.
Issue 2 - no cascade to upstream nodes
Let's assume the same graph and given order of connections:
gain1 -> gain2: both gains stays with 2ch
source -> gain1: gain1 shrinks to 1ch but it was not propagated to gain2
Issue 3 - stale buffers when batching connect calls
Let's consider given order of connect method calls:
On the second connect buffer of gain1 is still ch2 (first buffer negotiation is only queued),.
Checklist