[Simulation] Mapping graph: restrict construction of edges between groups and mappings - #6260
Open
alxbilger wants to merge 1 commit into
Open
[Simulation] Mapping graph: restrict construction of edges between groups and mappings#6260alxbilger wants to merge 1 commit into
alxbilger wants to merge 1 commit into
Conversation
…oups and mappings
Contributor
Author
|
[ci-build][with-all-tests] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash in
examples/Component/LinearSystem/MatrixLinearSystem.scn.This is complex scene showcasing the correct behavior of mappings in the matrix assembly.
This is the path to locate the bug:
⬇️
MatrixProjectionMethod.inl).⬇️
mappingGraph.getTopMostMechanicalStatesgives wrong inputs. For example, in the scene, it adds an unrelated input tored/FEM/DOFs. The unrelated input still contributes to the matrix, potentially to wrong locations.⬇️
The fix:
Mappings must be child of a group only if all the mapping inputs are all equal to the group's states. Previously, only one common state was enough.
After the fix:
The rigid mapping is no longer related to the blue DoFs.
This fix replaces #6222 and #6256
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if