[LinearSystem] MatrixProjectionMethod : add checks while adding to GlobalMatrix (in debug) - #6257
Open
fredroy wants to merge 1 commit into
Open
Conversation
alxbilger
approved these changes
Aug 25, 2026
alxbilger
approved these changes
Aug 25, 2026
alxbilger
left a comment
Contributor
There was a problem hiding this comment.
Tested with a problematic scene. I got the following error:
[ERROR] [MatrixProjectionMethod] A projected matrix block of size 120x960 placed at (0, 1080) does not fit into the global matrix of size 1200x1200. The block is ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
advised by Claude while trying to fix
I set only the checks only in debug to avoid loss of perf but maybe it could enabled in any case 🤔
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if