Skip to content

[Framework] Remove warnings by adding compilation time checks#6046

Open
fredroy wants to merge 2 commits intosofa-framework:masterfrom
fredroy:basedata_typename_constexpr
Open

[Framework] Remove warnings by adding compilation time checks#6046
fredroy wants to merge 2 commits intosofa-framework:masterfrom
fredroy:basedata_typename_constexpr

Conversation

@fredroy
Copy link
Contributor

@fredroy fredroy commented Mar 20, 2026

As suggested by some warnings of VS2022...

J:\0\src\Sofa\framework\Core\src\sofa/core/objectmodel/BaseData.h(294): warning C4127: conditional expression is constant
J:\0\src\Sofa\framework\Core\src\sofa/core/objectmodel/BaseData.h(294): note: consider using 'if constexpr' statement instead

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Mar 20, 2026
@fredroy fredroy changed the title [Core] BaseData: add a compilation time check for typename [Framework] Remove warnings by adding compilation time checks Mar 22, 2026
@fredroy fredroy force-pushed the basedata_typename_constexpr branch 3 times, most recently from 76be10c to 4fcc705 Compare March 23, 2026 03:51
@fredroy fredroy force-pushed the basedata_typename_constexpr branch from 4fcc705 to 4cd2a0f Compare March 23, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants