[SofaCarving] Add an example written in python#3457
[SofaCarving] Add an example written in python#3457fredroy merged 6 commits intosofa-framework:masterfrom
Conversation
|
This is to answer #3395 |
Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>
|
|
||
| #Function used only if this script is called from a python environment | ||
| if __name__ == '__main__': | ||
| main() |
There was a problem hiding this comment.
Instead of a global variable, please do something like
if __name__ == '__main__':
with_gui = False
if len(sys.args) == 2:
with_gui = sys.args[1] == "with-gui"
main(with_gui)Would be even better to use argparser https://docs.python.org/3/library/argparse.html instead of manually processing the args.
|
Hi @epernod, since you changed the label from wip to 'to review', you need to trigger the build manually with [ci-build]. Also, I would rebase this branch since it is an old one. |
|
[ci-build][with-all-tests] |
|
FYI, |
| root.addObject('BVHNarrowPhase') | ||
| root.addObject('MinProximityIntersection', name="Proximity", alarmDistance=0.08, contactDistance=0.05, useSurfaceNormals=False) | ||
| root.addObject('CollisionResponse', response="PenalityContactForceField") | ||
| root.addObject('CarvingManager',active=True, carvingDistance=-0.01, narrowPhaseDetection="@narrowPhase", toolModel="@Instrument/CollisionModel/ParticleModel") |
There was a problem hiding this comment.
To be picky, I would simply expect a comment explaining what the CarvingManager does and its data (for you user standpoint)
Else 👍
There was a problem hiding this comment.
Done @hugtalbot , before the method and before adding the component.
I would say, on s'en balek |
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if