Skip to content

fix(engine.io-client): prevent mutation of user-provided options #5471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
idirdev wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix(engine.io-client): prevent mutation of user-provided options #5471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/engine.io-client/lib/socket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,7 +1167,7 @@ export class Socket extends SocketWithUpgrade {
constructor(uri?: string, opts?: SocketOptions);
constructor(opts: SocketOptions);
constructor(uri?: string | SocketOptions, opts: SocketOptions = {}) {
const o = typeof uri === "object" ? uri : opts;
const o = typeof uri === "object" ? { ...uri } : { ...opts };

if (
!o.transports ||
Expand Down
8 changes: 8 additions & 0 deletions packages/engine.io-client/test/socket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ describe("Socket", function () {
});
});

it("should not mutate the options object", () => {
const options = { transports: ["websocket", "polling"] };
const originalTransports = [...options.transports];
const socket = new Socket(options);
expect(options.transports).to.eql(originalTransports);
socket.close();
});

it("throws an error when no transports are available", (done) => {
const socket = new Socket({ transports: [] });
let errorMessage = "";
Expand Down