Skip to content

Add TEXTAREA tests for \r and \r\n newline variants #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 4 commits into from
Closed

Add TEXTAREA tests for \r and \r\n newline variants #27

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9be5ebb
Initial plan
Copilot Feb 6, 2026
df9d744
Add TEXTAREA tests for \r and \r\n newline variants
Copilot Feb 6, 2026
4293b89
Add TEXTAREA tests for \r and \r\n newline variants
Copilot Feb 6, 2026
32e667f
Add assertEqualHTML to TEXTAREA tests and update ticket to 64609
Copilot Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions tests/phpunit/tests/html-api/wpHtmlProcessorModifiableText.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,56 @@ public function test_modifiable_text_special_textarea() {
);
}

/**
* TEXTAREA elements ignore the first newline in their content.
* Setting the modifiable text with a leading carriage return should be normalized
* and ensure the leading newline is present in the resulting TEXTAREA.
*
* @ticket 64609
*/
public function test_modifiable_text_special_textarea_carriage_return() {
$processor = WP_HTML_Processor::create_fragment( '<textarea></textarea>' );
$processor->next_token();
$processor->set_modifiable_text( "\rCR" );
// Newline normalization transforms \r into \n, and special handling should preserve it.
$this->assertSame(
"\nCR",
$processor->get_modifiable_text(),
'Should have normalized carriage return and preserved the leading newline in the TEXTAREA content.'
);
$this->assertEqualHTML(
"<textarea>\n\nCR</textarea>",
$processor->get_updated_html(),
'<body>',
'Should have doubled the newline in the output HTML to preserve the leading newline.'
);
}

/**
* TEXTAREA elements ignore the first newline in their content.
* Setting the modifiable text with a leading carriage return + newline should be normalized
* and ensure the leading newline is present in the resulting TEXTAREA.
*
* @ticket 64609
*/
public function test_modifiable_text_special_textarea_carriage_return_newline() {
$processor = WP_HTML_Processor::create_fragment( '<textarea></textarea>' );
$processor->next_token();
$processor->set_modifiable_text( "\r\nCR-N" );
// Newline normalization transforms \r\n into \n, and special handling should preserve it.
$this->assertSame(
"\nCR-N",
$processor->get_modifiable_text(),
'Should have normalized carriage return + newline and preserved the leading newline in the TEXTAREA content.'
);
$this->assertEqualHTML(
"<textarea>\n\nCR-N</textarea>",
$processor->get_updated_html(),
'<body>',
'Should have doubled the newline in the output HTML to preserve the leading newline.'
);
}

/**
* PRE and LISTING elements ignore the first newline in their content.
* Setting the modifiable text with a leading newline should ensure that the leading newline
Expand Down