Add TEXTAREA tests for \r and \r\n newline variants#27
Closed
Copilot wants to merge 4 commits intohtml-api/set-mod-html-leading-newlinesfrom
Closed
Add TEXTAREA tests for \r and \r\n newline variants#27Copilot wants to merge 4 commits intohtml-api/set-mod-html-leading-newlinesfrom
Copilot wants to merge 4 commits intohtml-api/set-mod-html-leading-newlinesfrom
Conversation
Co-authored-by: sirreal <841763+sirreal@users.noreply.github.com>
Co-authored-by: sirreal <841763+sirreal@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add tests for newline settings in modifiable HTML API
Add TEXTAREA tests for \r and \r\n newline variants
Feb 6, 2026
Co-authored-by: sirreal <841763+sirreal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test coverage for TEXTAREA elements with leading carriage return (
\r) and carriage return + newline (\r\n), matching the comprehensive test coverage for PRE and LISTING elements.Changes
test_modifiable_text_special_textarea_carriage_return()- Tests\rnormalization and preservationtest_modifiable_text_special_textarea_carriage_return_newline()- Tests\r\nnormalization and preservationget_modifiable_text()returns normalized content andassertEqualHTML()confirms doubled newline in outputCurrent Status
Tests expose implementation gap: TEXTAREA doesn't normalize
\r/\r\nto\nand preserve leading newlines like PRE/LISTING elements do. Tests will pass when implementation matches PRE/LISTING behavior.Trac ticket: https://core.trac.wordpress.org/ticket/64609
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
127.0.0.11REDACTED, pid is -1(packet block)https://api.github.com/repos/PHPCSStandards/PHPCSExtra/zipball/b598aa890815b8df16363271b659d73280129101/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/PHPCSStandards/PHPCSUtils/zipball/c216317e96c8b3f5932808f9b0f1f7a14e3bbf55/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/PHPCSStandards/PHP_CodeSniffer/zipball/0ca86845ce43291e8f5692c7356fccf3bcf02bf4/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/PHPCSStandards/composer-installer/zipball/845eb62303d2ca9b289ef216356568ccc075ffd1/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/PHPCompatibility/PHPCompatibility/zipball/9fb324479acf6f39452e0655d2429cc0d3914243/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/PHPCompatibility/PHPCompatibilityParagonie/zipball/244d7b04fc4bc2117c15f5abe23eb933b5f02bbf/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/PHPCompatibility/PHPCompatibilityWP/zipball/7c8d18b4d90dac9e86b0869a608fa09158e168fa/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/WordPress/WordPress-Coding-Standards/zipball/7795ec6fa05663d716a549d0b44e47ffc8b0d4a6/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/Yoast/PHPUnit-Polyfills/zipball/41aaac462fbd80feb8dd129e489f4bbc53fe26b0/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/composer/ca-bundle/zipball/1905981ee626e6f852448b7aaa978f8666c5bc54/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/doctrine/instantiator/zipball/c6222283fa3f4ac679f8b9ced9a4e23f163e80d0/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/myclabs/DeepCopy/zipball/07d290f0c47959fd5eed98c95ee5602db07e0b6a/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/nikic/PHP-Parser/zipball/dca41cd15c2ac9d055ad70dbfd011130757d1f82/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/phar-io/manifest/zipball/54750ef60c58e43759730615a392c31c80e23176/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/phar-io/version/zipball/4f7fd7836c6f332bb2933569e566a0d6c4cbed74/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/cli-parser/zipball/2b56bea83a09de3ac06bb18b92f068e60cc6f50b/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/code-unit-reverse-lookup/zipball/ac91f01ccec49fb77bdc6fd1e548bc70f7faa3e5/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/code-unit/zipball/1fc9f64c0927627ef78ba436c9b17d967e68e120/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/comparator/zipball/e4df00b9b3571187db2831ae9aada2c6efbd715d/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/complexity/zipball/25f207c40d62b8b7aa32f5ab026c53561964053a/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/diff/zipball/ba01945089c3a293b01ba9badc29ad55b106b0bc/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/environment/zipball/830c43a844f1f8d5b7a1f6d6076b784454d8b7ed/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/exporter/zipball/14c6ba52f95a36c3d27c835d65efc7123c446e8c/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/global-state/zipball/b6781316bdcd28260904e7cc18ec983d0d2ef4f6/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/lines-of-code/zipball/e1e4a170560925c26d424b6a03aed157e7dcc5c5/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/object-enumerator/zipball/5c9eeac41b290a3712d88851518825ad78f45c71/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/object-reflector/zipball/b4f479ebdbf63ac605d183ece17d8d7fe49c15c7/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/php-code-coverage/zipball/85402a822d1ecf1db1096959413d35e1c37cf1a5/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/php-file-iterator/zipball/cf1c2e7c203ac650e352f4cc675a7021e7d1b3cf/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/php-invoker/zipball/5a10147d0aaf65b58940a0b72f71c9ac0423cc67/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/php-text-template/zipball/5da5f67fc95621df9ff4c4e5a84d6a8a2acf7c28/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/php-timer/zipball/5a63ce20ed1b5bf577850e2c4e87f4aa902afbd2/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/phpunit/zipball/b36f02317466907a230d3aa1d34467041271ef4a/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/recursion-context/zipball/539c6691e0623af6dc6f9c20384c120f963465a0/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/resource-operations/zipball/05d5692a7993ecccd56a03e40cd7e5b09b1d404e/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/type/zipball/75e2c2a32f5e0b3aef905b9ed0b179b953b3d7c7/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/sebastianbergmann/version/zipball/c6c1022351a901512170118436c764e473f6de8c/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)https://api.github.com/repos/theseer/tokenizer/zipball/b7489ce515e168639d17feec34b8847c326b0b3c/usr/local/bin/php php /usr/bin/composer update -W velo�� pegjs --format c-- rc/dart(http block)translate.wordpress.org/home/REDACTED/work/_temp/ghcca-node/node/bin/node node i18n-cache/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.