-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(sso): removed provider specific OIDC logic from SSO registration & deregistration scripts #2896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…upport for Entra ID
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR successfully removes provider-specific hardcoded OIDC logic (Okta, Auth0, IdentityServer patterns) and replaces it with a more flexible approach that supports both explicit endpoint configuration and standard OIDC discovery. Key Changes:
Issues Found:
Confidence Score: 4/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 files reviewed, 1 comment
b6e2652 to
857d43f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 files reviewed, 2 comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Summary
Type of Change
Testing
Tested manually, ran tests with 10 of the most common OIDC providers to validate the method works
Checklist