Skip to content

Commit 857d43f

Browse files
committed
ack PR comment
1 parent 515ae61 commit 857d43f

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

packages/db/scripts/register-sso-provider.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,12 @@ async function registerSSOProvider(): Promise<boolean> {
391391
}
392392

393393
if (ssoConfig.providerType === 'oidc' && ssoConfig.oidcConfig) {
394-
if (!ssoConfig.oidcConfig.authorizationEndpoint) {
394+
const hasAllEndpoints =
395+
ssoConfig.oidcConfig.authorizationEndpoint &&
396+
ssoConfig.oidcConfig.tokenEndpoint &&
397+
ssoConfig.oidcConfig.jwksEndpoint
398+
399+
if (!hasAllEndpoints) {
395400
const discoveryUrl = `${ssoConfig.issuer.replace(/\/$/, '')}/.well-known/openid-configuration`
396401
logger.info('Fetching OIDC discovery document...', { discoveryUrl })
397402

@@ -424,12 +429,9 @@ async function registerSSOProvider(): Promise<boolean> {
424429
}
425430

426431
ssoConfig.oidcConfig.authorizationEndpoint = discovery.authorization_endpoint
427-
ssoConfig.oidcConfig.tokenEndpoint =
428-
ssoConfig.oidcConfig.tokenEndpoint || discovery.token_endpoint
429-
ssoConfig.oidcConfig.userInfoEndpoint =
430-
ssoConfig.oidcConfig.userInfoEndpoint || discovery.userinfo_endpoint
431-
ssoConfig.oidcConfig.jwksEndpoint =
432-
ssoConfig.oidcConfig.jwksEndpoint || discovery.jwks_uri
432+
ssoConfig.oidcConfig.tokenEndpoint = discovery.token_endpoint
433+
ssoConfig.oidcConfig.userInfoEndpoint = discovery.userinfo_endpoint
434+
ssoConfig.oidcConfig.jwksEndpoint = discovery.jwks_uri
433435

434436
logger.info('✅ Successfully fetched OIDC endpoints from discovery', {
435437
authorizationEndpoint: ssoConfig.oidcConfig.authorizationEndpoint,

0 commit comments

Comments
 (0)