improvement(monorepo): added tsconfig package, resolved type errors in testing package#2613
Merged
waleedlatif1 merged 1 commit intostagingfrom Dec 28, 2025
Merged
Conversation
…n testing package
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryCreated a centralized Key Changes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Root as Root package.json
participant TSConfig as @sim/tsconfig
participant Apps as Apps (sim, docs)
participant Pkgs as Packages (db, logger, cli, ts-sdk, testing)
participant Docker as Docker Build
Note over Dev,Docker: Phase 1: Create Shared TSConfig Package
Dev->>TSConfig: Create new @sim/tsconfig package
Dev->>TSConfig: Add base.json (ES2022, strict, bundler)
Dev->>TSConfig: Add nextjs.json (extends base + DOM + jsx)
Dev->>TSConfig: Add library.json (extends base + declarations, noEmit)
Dev->>TSConfig: Add library-build.json (extends base + emit)
Dev->>TSConfig: Define package.json exports
Note over Dev,Docker: Phase 2: Update Testing Package Types
Dev->>Pkgs: Relax testing package types to use 'any'
Dev->>Pkgs: Add eslint-disable for @typescript-eslint/no-explicit-any
Dev->>Pkgs: Update factories to return 'any' for flexibility
Dev->>Pkgs: Add nanoid dependency to testing package
Dev->>Pkgs: Update testing package tsconfig to extend @sim/tsconfig/library.json
Note over Dev,Docker: Phase 3: Migrate All TSConfigs
Dev->>Apps: Update apps/sim/tsconfig.json to extend @sim/tsconfig/nextjs.json
Dev->>Apps: Update apps/docs/tsconfig.json to extend @sim/tsconfig/nextjs.json
Dev->>Pkgs: Update packages/db to extend @sim/tsconfig/library.json
Dev->>Pkgs: Update packages/logger to extend @sim/tsconfig/library.json
Dev->>Pkgs: Update packages/cli to extend @sim/tsconfig/library-build.json
Dev->>Pkgs: Update packages/ts-sdk to extend @sim/tsconfig/library-build.json
Note over Dev,Docker: Phase 4: Fix App Test Type Errors
Dev->>Apps: Update utils.test.ts to use legacySubBlocks() helper
Dev->>Apps: Add explicit type assertions in store.test.ts
Dev->>Apps: Import operation types for proper casting
Note over Dev,Docker: Phase 5: Update Dependencies & Docker
Dev->>Root: Move misplaced dependencies from root to apps/sim
Dev->>Apps: Add @sim/tsconfig to all package devDependencies
Dev->>Docker: Add tsconfig package to Docker build stages
Dev->>Docker: Update isolated-vm path for Bun's new structure
Note over Dev,Docker: Phase 6: Branding Consistency
Dev->>Apps: Update User-Agent from "SimStudio" to "Sim" (11 files)
Note over Dev,Docker: Result: Centralized TS config, resolved type errors
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist