fix(build): add tsconfig to db dockerfile#2617
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR adds the Changes made:
Context: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Developer
participant Docker as Docker Build
participant Deps as Dependencies Stage
participant Runner as Runner Stage
participant TSConfig as @sim/tsconfig Package
participant DB as @sim/db Package
Developer->>Docker: Build db.Dockerfile
Docker->>Deps: Start dependencies stage
Deps->>Deps: Create packages/db and packages/tsconfig directories
Deps->>Deps: Copy package.json files for db and tsconfig
Deps->>Deps: Run bun install (resolves workspace dependencies)
Docker->>Runner: Start runner stage
Runner->>Runner: Copy node_modules from deps stage
Runner->>Runner: Copy drizzle.config.ts
Runner->>TSConfig: Copy packages/tsconfig directory
Note over TSConfig: Contains base.json, library.json, etc.
Runner->>DB: Copy packages/db directory
Note over DB: db/tsconfig.json extends @sim/tsconfig/library.json
DB->>TSConfig: Resolve workspace symlink
Note over DB,TSConfig: TypeScript can now resolve shared configs
|
There was a problem hiding this comment.
Additional Comments (1)
-
docker/db.Dockerfile, line 39 (link)logic: Missing
packages/tsconfigcopy to runner stage. The@sim/dbpackage extends@sim/tsconfig/library.jsonin its tsconfig, and when TypeScript resolves this at runtime (e.g., during type-checking withbun run type-check), it needs the actual tsconfig files. Since onlynode_modulesis copied (line 33), the workspace symlink would be broken.
1 file reviewed, 1 comment
|
@greptile |
Summary
Type of Change
Testing
N/A
Checklist