Revert tree expansion logical changes from SDK modernization commit#775
Revert tree expansion logical changes from SDK modernization commit#775johnml1135 merged 1 commit intomainfrom
Conversation
7fcf15b to
54327c9
Compare
1. Slice.cs: Restore expansion logic to != "doNotExpand" (expand by default) instead of == "expanded" (collapsed by default) This fixes LT-22469
54327c9 to
214de97
Compare
|
I was also trying to get other changes into this PR initially, but they were harder to tease out. Splitting those into a follow up commit. |
johnml1135
left a comment
There was a problem hiding this comment.
@johnml1135 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jasonleenaylor).
There was a problem hiding this comment.
Pull request overview
Reverts unintended behavioral changes introduced during a .NET modernization commit, restoring prior UI tree expansion behavior and (per description) native stack dumping behavior.
Changes:
- Restores default-expand behavior for slices unless explicitly marked
doNotExpand. - (Per PR description) restores prior symbol line loading and SEH-based stack capture in stack dump components.
| // || (XmlUtils.GetOptionalAttributeValue(caller, "expansion") == "expanded") | ||
| // || Expansion == DataTree.TreeItemState.ktisCollapsedEmpty) | ||
| bool fExpand = XmlUtils.GetOptionalAttributeValue(node, "expansion") == "expanded"; | ||
| bool fExpand = XmlUtils.GetOptionalAttributeValue(node, "expansion") != "doNotExpand"; |
There was a problem hiding this comment.
The string literal "doNotExpand" is a protocol value that’s easy to mistype and hard to discover/refactor. Consider centralizing it as a named constant (or using an enum-like pattern) and, if this value is intended to be case-insensitive in XML, using an explicit StringComparison to make that contract clear.
| bool fExpand = XmlUtils.GetOptionalAttributeValue(node, "expansion") != "doNotExpand"; | |
| const string DoNotExpandExpansionValue = "doNotExpand"; | |
| bool fExpand = XmlUtils.GetOptionalAttributeValue(node, "expansion") != DoNotExpandExpansionValue; |
Reverts behavioral changes in 5711bf6 that were unconnected to the .NET modernization
[For future PR]
2. StackDumperWin64.cpp: Restore SymGetLineFromAddr64 GetProcAddress loading
3. StackDumper.cpp: Restore real stack capture via SEH in DumpStackHere
This change is