Skip to content

Revert tree expansion logical changes from SDK modernization commit#775

Merged
johnml1135 merged 1 commit intomainfrom
LT-22469
Mar 23, 2026
Merged

Revert tree expansion logical changes from SDK modernization commit#775
johnml1135 merged 1 commit intomainfrom
LT-22469

Conversation

@jasonleenaylor
Copy link
Contributor

@jasonleenaylor jasonleenaylor commented Mar 20, 2026

Reverts behavioral changes in 5711bf6 that were unconnected to the .NET modernization

  1. Slice.cs: Restore default-expand behavior (expansion != "doNotExpand") fix LT-22469

[For future PR]
2. StackDumperWin64.cpp: Restore SymGetLineFromAddr64 GetProcAddress loading
3. StackDumper.cpp: Restore real stack capture via SEH in DumpStackHere


This change is Reviewable

@github-actions
Copy link

github-actions bot commented Mar 20, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   6m 13s ⏱️ +24s
4 074 tests ±0  4 003 ✅ ±0  71 💤 ±0  0 ❌ ±0 
4 083 runs  ±0  4 012 ✅ ±0  71 💤 ±0  0 ❌ ±0 

Results for commit 214de97. ± Comparison against base commit b6ac397.

♻️ This comment has been updated with latest results.

1. Slice.cs: Restore expansion logic to != "doNotExpand" (expand by
   default) instead of == "expanded" (collapsed by default)
   This fixes LT-22469
@jasonleenaylor
Copy link
Contributor Author

I was also trying to get other changes into this PR initially, but they were harder to tease out. Splitting those into a follow up commit.

@jasonleenaylor jasonleenaylor changed the title Revert 3 unrelated logical changes from SDK modernization commit Revert tree expansion logical changes from SDK modernization commit Mar 20, 2026
@jasonleenaylor jasonleenaylor marked this pull request as ready for review March 20, 2026 20:47
Copy link
Contributor

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@johnml1135 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on jasonleenaylor).

@johnml1135 johnml1135 merged commit 96872c2 into main Mar 23, 2026
9 of 11 checks passed
@johnml1135 johnml1135 deleted the LT-22469 branch March 23, 2026 10:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts unintended behavioral changes introduced during a .NET modernization commit, restoring prior UI tree expansion behavior and (per description) native stack dumping behavior.

Changes:

  • Restores default-expand behavior for slices unless explicitly marked doNotExpand.
  • (Per PR description) restores prior symbol line loading and SEH-based stack capture in stack dump components.

// || (XmlUtils.GetOptionalAttributeValue(caller, "expansion") == "expanded")
// || Expansion == DataTree.TreeItemState.ktisCollapsedEmpty)
bool fExpand = XmlUtils.GetOptionalAttributeValue(node, "expansion") == "expanded";
bool fExpand = XmlUtils.GetOptionalAttributeValue(node, "expansion") != "doNotExpand";
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string literal "doNotExpand" is a protocol value that’s easy to mistype and hard to discover/refactor. Consider centralizing it as a named constant (or using an enum-like pattern) and, if this value is intended to be case-insensitive in XML, using an explicit StringComparison to make that contract clear.

Suggested change
bool fExpand = XmlUtils.GetOptionalAttributeValue(node, "expansion") != "doNotExpand";
const string DoNotExpandExpansionValue = "doNotExpand";
bool fExpand = XmlUtils.GetOptionalAttributeValue(node, "expansion") != DoNotExpandExpansionValue;

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants