Revert tree expansion regression introduced in 5711bf6

jasonleenaylor · jasonleenaylor · commit 214de97262d8 · 2026-03-20T13:45:23.000-07:00
1. Slice.cs: Restore expansion logic to != "doNotExpand" (expand by
   default) instead of == "expanded" (collapsed by default)
   This fixes LT-22469
diff --git a/Src/Common/Controls/DetailControls/Slice.cs b/Src/Common/Controls/DetailControls/Slice.cs
@@ -1130,7 +1130,7 @@ public virtual void GenerateChildren(XmlNode node, XmlNode caller, ICmObject obj
 				//				|| (fUseChildrenOfNode && XmlUtils.GetOptionalAttributeValue(node, "expansion") == "expanded")
 				//				|| (XmlUtils.GetOptionalAttributeValue(caller, "expansion") == "expanded")
 				//				|| Expansion == DataTree.TreeItemState.ktisCollapsedEmpty)
-				bool fExpand = XmlUtils.GetOptionalAttributeValue(node, "expansion") == "expanded";
+				bool fExpand = XmlUtils.GetOptionalAttributeValue(node, "expansion") != "doNotExpand";
 				if (fUsePersistentExpansion && m_mediator != null) // mediator null only in testing?
 				{
 					Expansion = DataTree.TreeItemState.ktisCollapsed; // Needs to be an expandable state to have ExpansionStateKey.

Original file line number	Diff line number	Diff line change
`@@ -1130,7 +1130,7 @@ public virtual void GenerateChildren(XmlNode node, XmlNode caller, ICmObject obj`
`1130`	`1130`	`// \|\| (fUseChildrenOfNode && XmlUtils.GetOptionalAttributeValue(node, "expansion") == "expanded")`
`1131`	`1131`	`// \|\| (XmlUtils.GetOptionalAttributeValue(caller, "expansion") == "expanded")`
`1132`	`1132`	`// \|\| Expansion == DataTree.TreeItemState.ktisCollapsedEmpty)`
`1133`		`- bool fExpand = XmlUtils.GetOptionalAttributeValue(node, "expansion") == "expanded";`
	`1133`	`+ bool fExpand = XmlUtils.GetOptionalAttributeValue(node, "expansion") != "doNotExpand";`
`1134`	`1134`	`if (fUsePersistentExpansion && m_mediator != null) // mediator null only in testing?`
`1135`	`1135`	`{`
`1136`	`1136`	`Expansion = DataTree.TreeItemState.ktisCollapsed; // Needs to be an expandable state to have ExpansionStateKey.`