feat: split comma-separated values to repeated flags #12475
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanduur
force-pushed
the
feat/multiple-args
branch
from
e979d05 to
b6d11b7
Compare
There are some cases when comma-separated values are not interpreted the same way as multiple appearances of the same flag. We want to support multiple appearances of the same flag while keeping the current API signature - e.g., for gRPC proto messages. Signed-off-by: Mateusz Urbanek <mateusz.urbanek@siderolabs.com>
shanduur
force-pushed
the
feat/multiple-args
branch
from
b6d11b7 to
7f2306b
Compare
shanduur
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some cases when comma-separated values are not interpreted the
same way as multiple appearances of the same flag (see #11694). We want to support
multiple appearances of the same flag while keeping the current API
signature - e.g., for gRPC proto messages.
Fixes #11694
Signed-off-by: Mateusz Urbanek mateusz.urbanek@siderolabs.com