feat: split coma separated values to repeated flags

There are some cases when coma separated values are not interpreted the
same way as multiple apperance of the same flag. We want to support
multiple apperances of the same flag while keeping the curent API
signature - e.g. for gRPC proto messages.

Signed-off-by: Mateusz Urbanek <mateusz.urbanek@siderolabs.com>

Author: shanduur

pkg/argsbuilder/argsbuilder_args.go

@@ -97,7 +97,13 @@ func (a Args) Args() []string {
 	args := make([]string, 0, len(a))
 
 	for _, key := range keys {
-		args = append(args, fmt.Sprintf("--%s=%s", key, a[key]))
+		if strings.Contains(a[key], ",") {
+			for val := range strings.SplitSeq(a[key], ",") {
+				args = append(args, fmt.Sprintf("--%s=%s", key, val))
+			}
+		} else {
+			args = append(args, fmt.Sprintf("--%s=%s", key, a[key]))
+		}
 	}
 
 	return args

pkg/argsbuilder/argsbuilder_test.go

@@ -33,7 +33,7 @@ func (suite *ArgsbuilderSuite) TestMergeAdditive() {
 	)
 
 	suite.Require().Equal("value1,value2,value3,value10", args["param"])
-	suite.Assert().Equal([]string{"--param=value1,value2,value3,value10", "--param2="}, args.Args())
+	suite.Assert().Equal([]string{"--param=value1", "--param=value2", "--param=value3", "--param=value10", "--param2="}, args.Args())
 
 	suite.Require().NoError(
 		args.Merge(argsbuilder.Args{
@@ -46,7 +46,7 @@ func (suite *ArgsbuilderSuite) TestMergeAdditive() {
 	)
 
 	suite.Require().Equal("value1,value5", args["param2"])
-	suite.Assert().Equal([]string{"--param=value1,value2,value3,value10", "--param2=value1,value5"}, args.Args())
+	suite.Assert().Equal([]string{"--param=value1", "--param=value2", "--param=value3", "--param=value10", "--param2=value1", "--param2=value5"}, args.Args())
 }
 
 func (suite *ArgsbuilderSuite) TestMergeOverwrite() {