Skip to content

fix: ts type check#149

Open
Lars Kemper (larskemper) wants to merge 9 commits intotrunkfrom
fix/ts-config
Open

fix: ts type check#149
Lars Kemper (larskemper) wants to merge 9 commits intotrunkfrom
fix/ts-config

Conversation

@larskemper
Copy link
Copy Markdown
Member

@larskemper Lars Kemper (larskemper) commented Mar 3, 2026 •
edited
Loading

Changes

  • adds missing typescript type check to ci
  • adds missing axios dependency for types
  • fixes type issues
  • refactor api service types
  • decoupling of shopware global types

@larskemper Lars Kemper (larskemper) mentioned this pull request Mar 3, 2026
Closed
@larskemper Lars Kemper (larskemper) marked this pull request as ready for review March 3, 2026 14:54
MalteJanz
Malte Janz (MalteJanz) reviewed Mar 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@MalteJanz Malte Janz (MalteJanz) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking over, not sure if this is the solution we should accept though or if we can do better than this 🤔

@larskemper Lars Kemper (larskemper) marked this pull request as draft March 4, 2026 06:59
@larskemper Lars Kemper (larskemper) marked this pull request as ready for review April 1, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MalteJanz Malte Janz (MalteJanz) MalteJanz approved these changes

@jozsefdamokos Jozsef Damokos (jozsefdamokos) Awaiting requested review from jozsefdamokos jozsefdamokos was automatically assigned from shopware/product-cc-after-sales

@CR0YD Simon Fiebranz (CR0YD) Awaiting requested review from CR0YD CR0YD was automatically assigned from shopware/product-cc-after-sales

@ennasus4sun Susanne Hartung (ennasus4sun) Awaiting requested review from ennasus4sun ennasus4sun was automatically assigned from shopware/product-cc-after-sales

@DennisGarding Dennis Garding (DennisGarding) Awaiting requested review from DennisGarding

@vintagesucks Nikolas Evers (vintagesucks) Awaiting requested review from vintagesucks

Assignees

@larskemper Lars Kemper (larskemper)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@larskemper @DennisGarding @vintagesucks @MalteJanz