chore: fix typescript types and migration api service#148
chore: fix typescript types and migration api service#148Malte Janz (MalteJanz) wants to merge 2 commits intotrunkfrom
Conversation
Malte Janz (MalteJanz)
changed the title
| // todo: remove me, this is just to test our typescript linting | ||
| export const aNumber: string = 42; |
There was a problem hiding this comment.
Lars Kemper (@larskemper) maybe you can help me investigate what's going on when you are back 🙈 .
I already tried to look at other tsconfig.json files of our other plugins but so far didn't find a proper config that only checks our plugin files, but still allows importing type from the core 🤔
The highlighting in the IDE (PHPStorm) seems to work fine for the most part.
I'm a bit confused right now 🤯
There was a problem hiding this comment.
yep, exactly my problem doing this in the first place 😅 . Will take a look
There was a problem hiding this comment.
feel free to take over / commit to this PR. Unfortunately I'm in meetings all day, otherwise I would have suggested to take a look together 🙈
There was a problem hiding this comment.
also not really an idea, but i guess we could do something like this: https://github.com/shopware/SwagMigrationAssistant/pull/149/changes#diff-24da125432db6a98cab560db54b6abf35a172a6023048c271ccce5774cceb6f1R8
at least catches the type issues in our code
|
covered by #149 |
2 participants
Looks like our Typescript setup in our plugin is a little broken right now.
I tried to clean up some wrong types a little bit, but ideally I would also like to:
@ts-ignorecomments inswag-migration.api.service.tsApiServicetype from the core, without importing code into our bundle. So we get proper type information for all the methods / fields of the base classcomposer run lint:admincommand as well as in our CI