Skip to content

update react-router-dom and vite dependencies to address security vulnerabilities #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brianlenz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update react-router-dom and vite dependencies to address security vulnerabilities #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/jsx-email/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
"postcss-var-replace": "^1.0.0",
"pretty-bytes": "^6.1.1",
"qrcode-generator": "^2.0.4",
"react-router-dom": "7.12.0",
"react-router-dom": "7.18.0",

@greptile-apps greptile-apps Bot Jun 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 react-router-dom is pinned to an exact version rather than a patch-compatible range. This means future security patches for this package will require another manual PR instead of being picked up automatically by pnpm update. Using a patch-compatible range (^7.18.0) would let the lock file resolve the latest compatible release without manual intervention each time.

Suggested change
"react-router-dom": "7.18.0",
"react-router-dom": "^7.18.0",

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@brianlenz brianlenz Jun 16, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shellscape I agree with this feedback, but I was unsure of the reasoning for pinning the specific version, so I didn't want to make the change without your input.

"rehype": "^13.0.1",
"rehype-stringify": "^10.0.0",
"semver": "^7.7.1",
Expand Down
Loading