update react-router-dom and vite dependencies to address security vulnerabilities#461
Open
brianlenz wants to merge 1 commit into
Open
Conversation
| "pretty-bytes": "^6.1.1", | ||
| "qrcode-generator": "^2.0.4", | ||
| "react-router-dom": "7.12.0", | ||
| "react-router-dom": "7.18.0", |
There was a problem hiding this comment.
react-router-dom is pinned to an exact version rather than a patch-compatible range. This means future security patches for this package will require another manual PR instead of being picked up automatically by pnpm update. Using a patch-compatible range (^7.18.0) would let the lock file resolve the latest compatible release without manual intervention each time.
Suggested change
| "react-router-dom": "7.18.0", | |
| "react-router-dom": "^7.18.0", |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Author
There was a problem hiding this comment.
@shellscape I agree with this feedback, but I was unsure of the reasoning for pinning the specific version, so I didn't want to make the change without your input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component / Package Name:
This PR contains:
Are tests included?
Breaking Changes?
If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
resolves #460
Description
The dependency updates address the following vulnerabilities:
vite:
GHSA-fx2h-pf6j-xcff
GHSA-v6wh-96g9-6wx3
react-router-dom -> react-router:
GHSA-49rj-9fvp-4h2h
GHSA-8646-j5j9-6r62
GHSA-8x6r-g9mw-2r78
GHSA-rxv8-25v2-qmq8
GHSA-2j2x-hqr9-3h42
GHSA-f22v-gfqf-p8f3
GHSA-84g9-w2xq-vcv6