Open
Conversation
jeromekelleher
force-pushed
the
windows-support
branch
from
7d103d8 to
65fc2a1
Compare
- Add windows-latest to python_test matrix (Python 3.11) - Add platform marker to exclude cyvcf2 on Windows - Add pytestmark skip-on-Windows to test files needing cyvcf2/bcftools - Make cyvcf2 import lazy in tests/utils.py so non-cyvcf2 tests work - Skip Miniconda/bcftools/plink setup on Windows - Add Windows classifier
Add pytestmark skip-on-Windows to all test modules that reference the VCF data cache or other dependencies not available on Windows. Tests still running on Windows: test_calculate, test_cpython_interface, test_plink, test_regions, test_samples, test_utils.
Update message
jeromekelleher
force-pushed
the
windows-support
branch
from
f93ca64 to
1eba8a3
Compare
jeromekelleher
force-pushed
the
windows-support
branch
from
091c856 to
d62df47
Compare
jeromekelleher
force-pushed
the
windows-support
branch
from
d62df47 to
822ff4c
Compare
Member
Author
|
I think this is worth doing - we're not getting an awful lot of test coverage on windows at the moment, but I think that's OK. Going forward we can think of better ways to test things, hopefully, which won't required conversion of VCFs in CI. |
On Windows, _dup() shares the underlying OS handle rather than creating an independent copy. When fclose() closes the dup'd FILE*, it invalidates the original handle, causing an access violation when Python later closes its file object. Since print_state is only a debugging tool, exclude it on Windows via #ifndef _WIN32.
jeromekelleher
force-pushed
the
windows-support
branch
from
8f0b450 to
90897ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #273