Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a downstream CI trigger so that every successful merge to main in ros2_medkit can automatically kick off the integration demo suite in selfpatch/selfpatch_demos, keeping demo Docker builds synchronized with gateway changes.
Changes:
- Adds a new
notify-demosGitHub Actions job gated topushevents onmain. - Configures
notify-demosto wait forjazzy-lintandjazzy-testsuccess before dispatchingros2_medkit_updatedviarepository_dispatch. - Includes
shaandrun_urlinclient-payloadfor traceability back to the triggering workflow run.
- Guard against skipped upstream jobs by checking needs.jazzy-lint.result
and needs.jazzy-test.result == 'success' explicitly
- Replace fragile multi-line >- client-payload with a single-line string
- Add permissions: {} to document the job needs no GITHUB_TOKEN access
- Add comment documenting intentional Humble exclusion policy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Adds a
notify-demosjob to the CI workflow that dispatches arepository_dispatchevent toselfpatch/selfpatch_demosafter bothjazzy-lintandjazzy-testpass on pushes to main. This keeps the integration demo suite in sync with every gateway merge.pushtomain(skipped on PRs via theif:condition)jazzy-lintandjazzy-testto both succeed before dispatchingclient-payloadwithshaandrun_urlso the selfpatch_demos job summary can link back to the triggering gateway CI runpeter-evans/repository-dispatch@v4with theDEMOS_DISPATCH_TOKENsecret (fine-grained PAT withcontents:writeonselfpatch/selfpatch_demos)Issue
Type
Testing
The
notify-demosjob will be skipped on this PR (theif:condition evaluates to false forpull_requestevents). End-to-end validation will happen after both this PR and selfpatch/selfpatch_demos#36 are merged: the next push to main will dispatchros2_medkit_updatedto selfpatch_demos and trigger its CI.Pre-conditions:
DEMOS_DISPATCH_TOKENsecret is already configured in this repo (confirmed viagh secret list)ros2_medkit_updatedtrigger on the selfpatch_demos side) must be merged before this PR landsChecklist