feat: Add floating keyboard functionality to Scribe-Android (#261)#621
feat: Add floating keyboard functionality to Scribe-Android (#261)#621prince-0408 wants to merge 12 commits into
Conversation
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
… prevent keyboard cutting off on right in floating mode
|
praise: Hey @prince-0408 👋 This is really cool that we're getting to this! note: There are a few thing that are sticking out to me that I think we should rework :)
Let me know on the comments above! If you agree, then feel free to make the changes and then we can continue with the review :) |
Hey @andrewtavis 👋 Thanks for the feedback! These suggestions make a lot of sense:
I will get these changes implemented and push them shortly! |
…rdBase, and KeyboardUIManager
|
Hey @andrewtavis 👋 I've updated the branch with all your suggestions! The float button has been removed from the top command strip and reworked into a dedicated bottom-row key, command labels now swap to icons in floating mode to fit the smaller width, and orientation/resizing drawing glitches have been fixed. Here's a summary of everything implemented in this update: Summary of Changes
Visual Comparison
|
|
praise: Thanks for the quick reaction to the review, @prince-0408! All's looking great :) note: One thing that would be nice to have here is the keys should be a bit wider. Specifically the comma key and the flat key seem to be too narrow. Can we reduce the size of the space bar and make sure that those keys are appropriately sized? note: I'm discussing this with @angrezichatterbox and @henrikth93 right now, and we wanted to note that floating keyboards are normally controlled in the settings of the keyboard. We only have one keyboard setting that would need to be triggered in the keyboard UI now - this new floating keyboard - but if we were to get more, then we could switch that key to a settings key. |
|
note, @prince-0408: We've made #642 to add options to hide the keys for the floating keyboard and clipboard to make sure that they UI doesn't get to cluttered with keys that may not be being used. We'll get to that one once this is finalized. Please let us know if you need support with the last parts here! |
@andrewtavis I'm currently working on the final parts and will push an update soon. I'll definitely reach out if I need any support wrapping this up. Thanks! |
|
Let us know when this is ready for a final review, @prince-0408! :) |
… feedback; fix syntax error
|
Hey @andrewtavis 👋 Thanks for the feedback! I've just updated the branch to address the key sizing issue you pointed out, and I've also pulled in the latest changes from Everything is looking good on my end. Here's a summary of the latest updates: Summary of Changes
Updated Layout
Noted on the settings toggle in #642 as well! That sounds like a great plan for organizing the floating/clipboard features going forward. Please let me know if there's anything else needed before we finalize this! |
|
Hey @prince-0408 👋 Two comments on here, with the first being a nitpick and the second being something we need to look into here :)
|
On it @andrewtavis, will update soon |
|
Hey @andrewtavis 👋 Great catches on both issues! I've just pushed a few updates to address them. Here is a summary of the fixes:
PreviewsThe keyboard now floats perfectly in Google Messages without hiding the input field, and the float toggle key is visible in light mode. Everything should be working smoothly now. Let me know if you spot anything else! |
c8a4556 to
6ae29ad
Compare
|
Thanks for the further commits, @prince-0408! We'll try to get to a final review in the coming days :) CC @angrezichatterbox 👋 |







Description
This pull request implements and refines the floating keyboard functionality for Scribe-Android. It introduces a movable, resizable, and floating keyboard layout, and resolves various styling issues across both light and dark modes.
Adding this feature solves a major point of confusion during onboarding/development where developers couldn't locate the keyboard in emulators that default to a floating state. It also greatly improves the keyboard experience in full-screen games, split-screen multitasking, and landscape layouts on tablet/phone screens.
Closes #261
Changes Made
floating_drag_barwith visibility state tied to the floating preference.floating_drag_handlepill.resize_handle_top_left/rightandresize_handle_bottom_left/right).5dp) and wider (64dpcanvas) rounded capsule.32dp) to comfortably display the updated handle.resize_handle_colorfor both modes (#FF555555solid medium-dark grey in light mode, and#FFB0B0B0solid medium-light grey in dark mode).keyboard_cardto dynamically update its background color based on the current theme (dark_keyboard_bg_colororlight_keyboard_bg_color) instead of using a static light grey.Screenshots