Skip to content

feat: add setting to toggle clipboard key on keyboard#646

Open
prince-0408 wants to merge 1 commit into
scribe-org:mainfrom
prince-0408:feature/clipboard-setting-642
Open

feat: add setting to toggle clipboard key on keyboard#646
prince-0408 wants to merge 1 commit into
scribe-org:mainfrom
prince-0408:feature/clipboard-setting-642

Conversation

@prince-0408

@prince-0408 prince-0408 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Description

Related #642.

This PR adds a setting to the Layout section of the keyboard settings that allows users to toggle the visibility of the clipboard key on the keyboard UI.

Per the requirements:

Proposed Changes

Resources & i18n

  • Added localization keys for the clipboard toggle to the source string.xml (i18n.app.settings.keyboard.layout.clipboard_on_keyboard and i18n.app.settings.keyboard.layout.clipboard_on_keyboard_description).

Preferences & State

  • PreferencesHelper.kt: Added getIsClipboardKeyEnabled and setClipboardKeyPreference to save/retrieve user preference in SharedPreferences.
  • LanguageSettingsScreen.kt: Added a SwitchItem toggle for the clipboard setting inside the Layout settings list.

Keyboard Rendering

  • KeyboardBase.kt: Updated KeyboardContextProvider with isClipboardKeyEnabled() and wrapped the clipboard key layout block in adjustSpaceKeyWidthAndPosition to check this value.
  • GeneralKeyboardIME.kt: Implemented isClipboardKeyEnabled() to return the user's preference state.

Verification

  • Local code inspection completed; verifies clean and compliant Kotlin syntax.

Screenshots

Clipboard Setting Enabled Keyboard with Clipboard Key
Clipboard ON Setting Clipboard ON Keyboard
Clipboard Setting Disabled Keyboard without Clipboard Key
Clipboard OFF setting Clipboard Off Keyboard

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis

Copy link
Copy Markdown
Member

Edited the commit message as this won't close the issue :) Or maybe we can commit to this once the floating keyboard is done and close the issue then.

Regardless, @prince-0408, would you be able to look into the errors above?

@andrewtavis andrewtavis self-requested a review July 6, 2026 05:21
@andrewtavis andrewtavis added the -next release- Included in the next release label Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-next release- Included in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants