Skip to content

🎨 Align middleware override signatures with base class #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MiWeiss merged 4 commits into from
Jun 12, 2026
Merged

🎨 Align middleware override signatures with base class #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce9caac
🎨 Align middleware override signatures with base class
MiWeiss Jun 12, 2026
281d9e8
Merge branch 'main' into 539-override-signatures
MiWeiss Jun 12, 2026
2043c97
Merge branch 'main' into 539-override-signatures
MiWeiss Jun 12, 2026
3861010
Merge branch 'main' into 539-override-signatures
MiWeiss Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bibtexparser/middlewares/enclosing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def _enclose(
)

# docstr-coverage: inherited
def transform_entry(self, entry: Entry, *args, **kwargs) -> Entry:
def transform_entry(self, entry: Entry, library: Library) -> Entry:
field: Field
metadata_enclosing = entry.parser_metadata.pop(
RemoveEnclosingMiddleware.metadata_key(), None
Expand All @@ -186,7 +186,7 @@ def transform_entry(self, entry: Entry, *args, **kwargs) -> Entry:
return entry

# docstr-coverage: inherited
def transform_string(self, string: String, *args, **kwargs) -> String:
def transform_string(self, string: String, library: Library) -> String:
metadata_key = RemoveEnclosingMiddleware.metadata_key()
string.value = self._enclose(
string.value,
Expand Down
6 changes: 4 additions & 2 deletions bibtexparser/middlewares/latex_encoding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ def __init__(
self._encoder = encoder

# docstr-coverage: inherited
def metadata_key(self) -> str:
@classmethod
def metadata_key(cls) -> str:
return "latex_encoding"

# docstr-coverage: inherited
Expand Down Expand Up @@ -210,7 +211,8 @@ def __init__(
self._decoder = decoder

# docstr-coverage: inherited
def metadata_key(self) -> str:
@classmethod
def metadata_key(cls) -> str:
return "latex_decoding"

# docstr-coverage: inherited
Expand Down
3 changes: 2 additions & 1 deletion bibtexparser/middlewares/names.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from typing import Tuple
from typing import Union

from bibtexparser.library import Library
from bibtexparser.model import Block
from bibtexparser.model import Entry
from bibtexparser.model import Field
Expand Down Expand Up @@ -54,7 +55,7 @@ def _transform_field_value(self, name):
raise NotImplementedError("called abstract method")

# docstr-coverage: inherited
def transform_entry(self, entry: Entry, *args, **kwargs) -> Block:
def transform_entry(self, entry: Entry, library: Library) -> Block:
field: Field
try:
for field in entry.fields:
Expand Down
Loading