Skip to content

🎨 Align middleware override signatures with base class#553

Merged
MiWeiss merged 4 commits into
mainfrom
539-override-signatures
Jun 12, 2026
Merged

🎨 Align middleware override signatures with base class#553
MiWeiss merged 4 commits into
mainfrom
539-override-signatures

Conversation

@MiWeiss

@MiWeiss MiWeiss commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator
  • transform_entry/transform_string used *args, **kwargs instead of the base signature (self, block, library) in AddEnclosingMiddleware and _NameTransformerMiddleware
  • metadata_key was overridden as an instance method in the Latex middlewares although the base declares a classmethod

Fixes #539

🤖 Generated with Claude Code

@MiWeiss

MiWeiss commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

reviewed

@MiWeiss MiWeiss enabled auto-merge (squash) June 12, 2026 07:02
@MiWeiss MiWeiss disabled auto-merge June 12, 2026 07:02
@MiWeiss MiWeiss merged commit 0946685 into main Jun 12, 2026
31 checks passed
@MiWeiss MiWeiss deleted the 539-override-signatures branch June 12, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Override signature drift in middleware subclasses

1 participant