-
Notifications
You must be signed in to change notification settings - Fork 0
fix(webapp): refactor dev server URL detection @W-21331028@ #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
78b0adf
fix: refactor dev server URL detection
deepu-mungamuri94 f8e981b
refactor: replace explicitUrl/expectedUrl with single url option in D…
deepu-mungamuri94 1ad9d51
fix: add synchronize and workflow_dispatch to pr-validation trigger
deepu-mungamuri94 0aecac0
chore: remove workflow_dispatch from pr-validation
deepu-mungamuri94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like these changes may be removing existing content that still holds value. Please review the updates carefully and ensure that nothing is unintentionally overwritten, and that new changes are incorporated appropriately alongside the existing content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we restructured the url detection flow, we made changes to doc. I think we have the upto date doc with recent changes.
Any issues identified thats not inline or removed which supposed to be there ?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example,
Thewebapplication.jsonfile is **optional**. All fields are also optional - missing fields use defaults.got removed, ideally it should still be there or the text updated to mention that it is mandated not removed at al.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing major, just few minor updates. I want to ensure we don't remove stuff that is still valid.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is still there: https://github.com/salesforcecli/plugin-app-dev/blob/78b0adffabc5f0aeab0e954a727adf5c1c93b0e9/SF_WEBAPP_DEV_GUIDE.md#webapplicationjson-schema. I’ve refactored the document to remove duplicate information and improve the overall flow from the reader’s perspective.