fix(webapp): refactor dev server URL detection @W-21331028@#30
fix(webapp): refactor dev server URL detection @W-21331028@#30deepu-mungamuri94 merged 4 commits intomainfrom
Conversation
Made-with: Cursor
9dae8b9 to
78b0adf
Compare
|
|
||
| ## Configuration | ||
|
|
||
| ### webapplication.json Schema |
There was a problem hiding this comment.
It looks like these changes may be removing existing content that still holds value. Please review the updates carefully and ensure that nothing is unintentionally overwritten, and that new changes are incorporated appropriately alongside the existing content.
There was a problem hiding this comment.
Since we restructured the url detection flow, we made changes to doc. I think we have the upto date doc with recent changes.
Any issues identified thats not inline or removed which supposed to be there ?
There was a problem hiding this comment.
For example,
The webapplication.jsonfile is **optional**. All fields are also optional - missing fields use defaults.
got removed, ideally it should still be there or the text updated to mention that it is mandated not removed at al.
There was a problem hiding this comment.
Nothing major, just few minor updates. I want to ensure we don't remove stuff that is still valid.
There was a problem hiding this comment.
That is still there: https://github.com/salesforcecli/plugin-app-dev/blob/78b0adffabc5f0aeab0e954a727adf5c1c93b0e9/SF_WEBAPP_DEV_GUIDE.md#webapplicationjson-schema. I’ve refactored the document to remove duplicate information and improve the overall flow from the reader’s perspective.
.cursor/plans/dev_server_url_detection_IMPLEMENTATION_PROMPT.md
Outdated
Show resolved
Hide resolved
…evServerOptions Made-with: Cursor
c2be0f7 to
f8e981b
Compare
Made-with: Cursor
Made-with: Cursor
What does this PR do?
Refactors dev server URL detection from brittle stdout parsing to a configuration-driven approach:
--urlflag,dev.urlin manifest, or defaulthttp://localhost:5173(no stdout parsing)dev.portto manifest: Optional proxy port inwebapplication.json; precedence:--portflag >dev.portin manifest > default 4545{"url":"..."}to stderr when ready, so the VS Code extension can parse a single structured line instead of regex on human messagesWhat issues does this PR fix or reference?
@W-21331028@
Functionality Before
http://localhost:4545on timeoutFunctionality After
{"url":"..."}— human messages can change without breaking extensiondev.portin manifest for proxy port configuration