Skip to content

test(runtime): skip unavailable Playwright engines #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paralin merged 1 commit into from
Aug 12, 2026
Merged

test(runtime): skip unavailable Playwright engines #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 28 additions & 25 deletions gs/builtin/defer-browser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { execFileSync } from 'node:child_process'
import { mkdtempSync, readFileSync, rmSync } from 'node:fs'
import { existsSync, mkdtempSync, readFileSync, rmSync } from 'node:fs'
import { tmpdir } from 'node:os'
import { join } from 'node:path'
import { fileURLToPath } from 'node:url'
Expand Down Expand Up @@ -28,29 +28,32 @@ describe.each([
['Chromium', chromium],
['WebKit', webkit],
])('DisposableStack in %s', (_name, browserType) => {
it('supports generated using declarations', async () => {
const browser = await browserType.launch({ headless: true })
const page = await browser.newPage()
const errors: string[] = []
page.on('pageerror', (error) => errors.push(error.message))
it.skipIf(!existsSync(browserType.executablePath()))(
'supports generated using declarations',
async () => {
const browser = await browserType.launch({ headless: true })
const page = await browser.newPage()
const errors: string[] = []
page.on('pageerror', (error) => errors.push(error.message))

try {
await page.addScriptTag({ content: bundle })
expect(errors).toEqual([])
expect(
await page.evaluate(
async () => await globalThis.__goscriptDisposableStackResult,
),
).toEqual({
disposeSymbolPresent: _name === 'Chromium',
asyncDisposeSymbolPresent: _name === 'Chromium',
usesDisposeSymbol: true,
usesAsyncDisposeSymbol: true,
order: ['second', 'first', 'async'],
disposeError: 'deferred failure',
})
} finally {
await browser.close()
}
})
try {
await page.addScriptTag({ content: bundle })
expect(errors).toEqual([])
expect(
await page.evaluate(
async () => await globalThis.__goscriptDisposableStackResult,
),
).toEqual({
disposeSymbolPresent: _name === 'Chromium',
asyncDisposeSymbolPresent: _name === 'Chromium',
usesDisposeSymbol: true,
usesAsyncDisposeSymbol: true,
order: ['second', 'first', 'async'],
disposeError: 'deferred failure',
})
} finally {
await browser.close()
}
},
)
})
Loading