test(runtime): skip unavailable Playwright engines - #152
Merged
Conversation
Default CI does not install Playwright browser executables, so the direct browser regression must skip rows whose engine is unavailable. The focused installed-engine environment still runs both Chromium and WebKit rows, retaining the proof for the disposable-symbol fix without changing the runtime source or browser fixture. Signed-off-by: Christian Stewart <christian@aperture.us>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Playwright-powered browser regression test to automatically skip per-engine test cases when the corresponding Playwright browser executable is not present, aligning the test behavior with CI environments that do not install Playwright browsers by default.
Changes:
- Add a filesystem presence check for each Playwright engine’s
executablePath()and conditionally skip the test row when missing. - Update imports to include
existsSyncfor the executable availability check.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default CI does not install Playwright browser executables, so the direct browser regression must skip rows whose engine is unavailable. The focused installed-engine environment still runs both Chromium and WebKit rows, retaining the proof for the disposable-symbol fix without changing the runtime source or browser fixture.