Skip to content

Disable vm-memory default features #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
germag wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable vm-memory default features #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ pe = ["elf"]
elf = []

[dependencies]
vm-memory = ">=0.16.0, <=0.17.1"
vm-memory = { version = ">=0.16.0, <=0.17.1", default-features = false }

[dev-dependencies]
criterion = { version = "0.7.0", features = ["html_reports"] }
vm-memory = { version = ">=0.16.0, <=0.17.1", features = ["backend-mmap"] }
vm-memory = { version = ">=0.16.0, <=0.17.1", default-features = false, features = ["backend-mmap"] }

[[bench]]
name = "main"
Expand Down
2 changes: 2 additions & 0 deletions src/loader_gen/x86_64/bootparam.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,8 @@ pub struct __kernel_fd_set {
pub fds_bits: [::std::os::raw::c_ulong; 16usize],
}
#[test]
// On Windows the unsigned long size is 4 bytes, instead of 8
#[cfg(target_family = "unix")]
fn bindgen_test_layout___kernel_fd_set() {
Comment on lines 218 to 223
Copy link
Author

@germag germag Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is correct, since the fds_bits's size will be incorrect, should I change fds_bits to [::std::os::raw::c_ulonglong; 16usize] on Windows?

Copy link
Author

@germag germag Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slp

const UNINIT: ::std::mem::MaybeUninit<__kernel_fd_set> = ::std::mem::MaybeUninit::uninit();
let ptr = UNINIT.as_ptr();
Expand Down