Open
Conversation
By default vm-memory enables the "rawfd" feature, which causes the compilation to fail on windows. Signed-off-by: German Maglione <gmaglione@redhat.com>
germag
requested review from
ShadowCurse,
andreitraistaru,
rbradford,
roypat and
sameo
as code owners
germag
commented
Mar 26, 2026
Comment on lines
218
to
223
| pub fds_bits: [::std::os::raw::c_ulong; 16usize], | ||
| } | ||
| #[test] | ||
| // On Windows the unsigned long size is 4 bytes, instead of 8 | ||
| #[cfg(target_family = "unix")] | ||
| fn bindgen_test_layout___kernel_fd_set() { |
Author
There was a problem hiding this comment.
I'm not sure this is correct, since the fds_bits's size will be incorrect, should I change fds_bits to [::std::os::raw::c_ulonglong; 16usize] on Windows?
germag
commented
Mar 26, 2026
Comment on lines
253
to
255
| pub type __kernel_old_dev_t = ::std::os::raw::c_ulong; | ||
| pub type __kernel_long_t = ::std::os::raw::c_long; | ||
| pub type __kernel_ulong_t = ::std::os::raw::c_ulong; |
Author
There was a problem hiding this comment.
Same with these, should be changed to c_ulonglong ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
By default vm-memory enables the "rawfd" feature, which causes the compilation to fail on windows.
Requirements
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.