Skip to content

Rollup of 8 pull requests - #161566

Merged
rust-bors[bot] merged 38 commits into
rust-lang:mainfrom
jhpratt:rollup-PxRQM5u
Aug 23, 2026
Merged

Rollup of 8 pull requests#161566
rust-bors[bot] merged 38 commits into
rust-lang:mainfrom
jhpratt:rollup-PxRQM5u

Conversation

@jhpratt

@jhpratt jhpratt commented Aug 22, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

kx0101 and others added 30 commits May 5, 2026 00:34
This allows building the resulting workspace with --locked.
Revert "x86: Followup to add const for pack intrinsics and tests"
…ng_packs

Revert "x86: use `simd::intrinsics` for saturating packs"
Honor build.docs-minification=false for rustdoc suites run via
compiletest by forwarding --disable-minification to rustdoc.
This is motivated by rust-lang#160164,
which added the derive which wouldn't actually work, due to recusrive
trait bounds (more on this in a later commit). This change will make it
so that these errors are caught in rustc CI.
Becuase its implementations must uphold a soundness-critical invariant.
_mm_maskmoveu_si128 requires mutable in-bounds memory even when it does nothing
@rust-bors rust-bors Bot mentioned this pull request Aug 23, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 23, 2026
Rollup of 8 pull requests

Successful merges:

 - #161558 (stdarch subtree update)
 - #159887 (compiletest: forward disable-minification from bootstrap)
 - #160229 (Extend `dropping_{references,copy_types}` lints to `drop_in_place`)
 - #160949 (Add floating point inline ASM support for SPARC)
 - #156160 (feat: add symmetric PartialEq impls for Vec, &[T], &mut [T] versus Cow<'_, [T]>)
 - #160914 (Derive `GenericTypeVisitable` for `RegionConstraint` _correctly_)
 - #161341 (be more permissive wrt overflow and and improve diagnostics)
 - #161530 (Add regression test for gce dependency ICE in non-gce crate)
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job dist-aarch64-msvc failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 23, 2026
@rust-bors

rust-bors Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

💔 Test for b215b3c failed: CI. Failed job:

@jhpratt

jhpratt commented Aug 23, 2026

Copy link
Copy Markdown
Member Author

@bors treeclosed=1 spurious failures

@bors retry

@rust-bors

rust-bors Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Tree closed for PRs with priority less than 1.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2026
@rust-bors

This comment has been minimized.

@jhpratt

jhpratt commented Aug 23, 2026

Copy link
Copy Markdown
Member Author

@bors treeclosed-

@rust-bors

rust-bors Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Tree is now open for merging.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 23, 2026
@rust-bors

rust-bors Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 14m 20s
Pushing baf1f7c to main...

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2f54787 (parent) -> baf1f7c (this PR)

Test differences

Show 152 test diffs

Stage 0

  • directives::tests::disable_minification_flag: [missing] -> pass (J4)

Stage 1

  • vec::test_partial_eq_cow_symmetric: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/asm/sparc/reg-conflict.rs#sparc: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/asm/sparc/reg-conflict.rs#sparc64: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/asm/sparc/reg-conflict.rs#sparcv8plus: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/const-generics/generic_const_exprs/dependent-crate-no-gce-128525.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/traits/next-solver/overflow/fcw-overflow-to-ambig-with-constraints.rs#next: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/traits/next-solver/overflow/fcw-overflow-to-ambig-with-constraints.rs#old: [missing] -> pass (J1)
  • [ui] tests/ui/asm/sparc/reg-conflict.rs#sparc: [missing] -> pass (J3)
  • [ui] tests/ui/asm/sparc/reg-conflict.rs#sparc64: [missing] -> pass (J3)
  • [ui] tests/ui/asm/sparc/reg-conflict.rs#sparcv8plus: [missing] -> pass (J3)
  • [ui] tests/ui/const-generics/generic_const_exprs/dependent-crate-no-gce-128525.rs: [missing] -> pass (J3)
  • [ui] tests/ui/traits/next-solver/overflow/fcw-overflow-to-ambig-with-constraints.rs#next: [missing] -> pass (J3)
  • [ui] tests/ui/traits/next-solver/overflow/fcw-overflow-to-ambig-with-constraints.rs#old: [missing] -> pass (J3)
  • [assembly] tests/assembly-llvm/asm/sparc-types.rs#sparc: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J5)
  • [assembly] tests/assembly-llvm/asm/sparc-types.rs#sparc64: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J5)
  • [assembly] tests/assembly-llvm/asm/sparc-types.rs#sparcv8plus: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J5)

Stage 2

  • [ui] tests/ui/asm/sparc/reg-conflict.rs#sparc: [missing] -> pass (J2)
  • [ui] tests/ui/asm/sparc/reg-conflict.rs#sparc64: [missing] -> pass (J2)
  • [ui] tests/ui/asm/sparc/reg-conflict.rs#sparcv8plus: [missing] -> pass (J2)
  • [assembly] tests/assembly-llvm/asm/sparc-types.rs#sparc: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J6)
  • [assembly] tests/assembly-llvm/asm/sparc-types.rs#sparc64: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J6)
  • [assembly] tests/assembly-llvm/asm/sparc-types.rs#sparcv8plus: pass -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J6)
  • [ui] tests/ui/asm/sparc/reg-conflict.rs#sparc: [missing] -> ignore (gcc backend is marked as ignore) (J7)
  • [ui] tests/ui/asm/sparc/reg-conflict.rs#sparc64: [missing] -> ignore (gcc backend is marked as ignore) (J7)
  • [ui] tests/ui/asm/sparc/reg-conflict.rs#sparcv8plus: [missing] -> ignore (gcc backend is marked as ignore) (J7)
  • [ui] tests/ui/const-generics/generic_const_exprs/dependent-crate-no-gce-128525.rs: [missing] -> pass (J8)
  • [ui] tests/ui/traits/next-solver/overflow/fcw-overflow-to-ambig-with-constraints.rs#next: [missing] -> pass (J8)
  • [ui] tests/ui/traits/next-solver/overflow/fcw-overflow-to-ambig-with-constraints.rs#old: [missing] -> pass (J8)
  • vec::test_partial_eq_cow_symmetric: [missing] -> pass (J9)

Additionally, 122 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard baf1f7cc4faa79b938148ad52c53e96c0102cbc4 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple-1: 1h 52m -> 3h 12m (+70.9%)
  2. i686-gnu-nopt-1: 1h 26m -> 2h 4m (+44.1%)
  3. i686-gnu-2: 1h 1m -> 1h 28m (+42.8%)
  4. armhf-gnu: 1h 23m -> 51m 38s (-38.5%)
  5. x86_64-gnu-gcc-core-tests: 12m 16s -> 7m 47s (-36.5%)
  6. x86_64-gnu-stable: 2h 31m -> 1h 39m (-34.3%)
  7. x86_64-gnu-llvm-21-1: 43m 11s -> 57m 17s (+32.7%)
  8. x86_64-gnu-llvm-22-2: 1h 11m -> 1h 34m (+31.2%)
  9. x86_64-gnu-distcheck: 2h 13m -> 1h 32m (-30.5%)
  10. dist-x86_64-llvm-mingw: 2h 11m -> 1h 31m (-30.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (baf1f7c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.4%, secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.4% [1.4%, 1.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.2% [-3.2%, -3.2%] 1
All ❌✅ (primary) 1.4% [1.4%, 1.4%] 1

Cycles

Results (secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 470.877s -> 469.531s (-0.29%)
Artifact size: 400.19 MiB -> 400.26 MiB (0.02%)

@rust-bors

rust-bors Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#161558 stdarch subtree update fc623846d42479a841cea3416f7217cd7650f65b
(link)
#159887 compiletest: forward disable-minification from bootstrap 4637c9f221a9c00d9d449e32350bae6b5ddc2137
(link)
#160229 Extend dropping_{references,copy_types} lints to `drop_in… 06cf400f5ac2ac4f746eab36d8c5324719e05c72
(link)
#160949 Add floating point inline ASM support for SPARC a326dec954451093b71c2d298b54980383850149
(link)
#156160 feat: add symmetric PartialEq impls for Vec, &[T], &mut [T]… 4f420e957a54f601ab4825089e3eea2cdd30df03
(link)
#160914 Derive GenericTypeVisitable for RegionConstraint _corre… 76d6ede91bea97e3b4257f35c9c0dff739d8ada7
(link)
#161341 be more permissive wrt overflow and and improve diagnostics 448505c74fa163c01a0d155f8abd9ba1ca57c174
(link)
#161530 Add regression test for gce dependency ICE in non-gce crate d343ff8116e849a966e6586392c581cd565de15b
(link)

parent commit: 2f54787b63

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.