also trigger overflow FCW when going from overflow -> error - #161552
Open
lcnr wants to merge 3 commits into
Open
also trigger overflow FCW when going from overflow -> error#161552lcnr wants to merge 3 commits into
lcnr wants to merge 3 commits into
Conversation
Collaborator
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
rustbot
added
S-waiting-on-review
Contributor
Author
|
am also adding "and so on..." to the error as it makes it clearer that these are not all involved goals |
lcnr
force-pushed
the
overflow-fcw-chain
branch
from
August 22, 2026 18:50
dcf5e9d to
8b94c34
Compare
This comment has been minimized.
This comment has been minimized.
lcnr
force-pushed
the
overflow-fcw-chain
branch
from
August 22, 2026 19:49
25872b9 to
0debf6e
Compare
This comment has been minimized.
This comment has been minimized.
lcnr
force-pushed
the
overflow-fcw-chain
branch
from
August 23, 2026 07:53
0debf6e to
50f711c
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
lcnr
force-pushed
the
overflow-fcw-chain
branch
from
August 23, 2026 08:09
50f711c to
47b9a4a
Compare
This is not strictly necessary night now, but feels like it'd be a lot better for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #161341. This changes the FCW to also trigger if doubling the recursion limit changes things to an error.
Fixes bevyengine/bevy#25511
I am also changing
fn root_goal_may_hold_opaque_types_jankto just useevaluate_root_goal. That isn't necessary for the example itself but we previously didn't do the FCW in there, which feels subtle and brittle. THis should just generally be more consistentr? adwinwhite (or anyone else really)