Skip to content

Comments

show average build durations in build lists, crate details#3172

Merged
syphar merged 2 commits intorust-lang:mainfrom
syphar:build-durations-new
Jan 30, 2026
Merged

show average build durations in build lists, crate details#3172
syphar merged 2 commits intorust-lang:mainfrom
syphar:build-durations-new

Conversation

@syphar
Copy link
Member

@syphar syphar commented Jan 29, 2026

This is mostly a new try to do #3134 (which was reverted in #3146 due to performance issues).

I actually was already working on storing the duration in the database and not calculate them on the fly,
but then I decided to dig into the actual performance issues on a restored production backup.

The issues were mostly:

  1. missing indexes (one on a primary key! not sure how this slipped the cracks until now)
  2. postgres not handling the views well.

Now we don't have the views any more, fast queries, but some duplication between the queries.

UI is still the same as in #3134

@syphar syphar requested a review from a team as a code owner January 29, 2026 20:41
@syphar syphar self-assigned this Jan 29, 2026
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jan 29, 2026
@syphar syphar force-pushed the build-durations-new branch 3 times, most recently from 1bcca8a to cf05fd7 Compare January 30, 2026 06:17
@syphar syphar force-pushed the build-durations-new branch from cf05fd7 to 2c42292 Compare January 30, 2026 06:30
@syphar syphar merged commit 4356998 into rust-lang:main Jan 30, 2026
11 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jan 30, 2026
@syphar syphar deleted the build-durations-new branch February 6, 2026 16:20
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants