fix crate-details view when there are no builds

Author: syphar

…f08566aecfa06e6a2c4a146b54213498b77.json …1d9a17670801c85b53b235b306ec8eef95e.jsoncrates/bin/docs_rs_web/.sqlx/query-9399c68093aa75e16820173a658ecf08566aecfa06e6a2c4a146b54213498b77.json renamed to .sqlx/query-2c7c1c2f69ccea2fbb16d6d7706b41d9a17670801c85b53b235b306ec8eef95e.json crates/bin/docs_rs_web/.sqlx/query-9399c68093aa75e16820173a658ecf08566aecfa06e6a2c4a146b54213498b77.json renamed to .sqlx/query-2c7c1c2f69ccea2fbb16d6d7706b41d9a17670801c85b53b235b306ec8eef95e.json

@@ -203,8 +203,9 @@ async fn get_builds(
                 ELSE
                     CASE
                         -- for in-progress builds we show the duration until now
-                        WHEN builds.build_finished IS NULL
-                            THEN (CURRENT_TIMESTAMP - builds.build_started)
+                        WHEN builds.build_status = 'in_progress' THEN (CURRENT_TIMESTAMP - builds.build_started)
+                        -- there are broken builds where the status is `error`, and `build_finished` is NULL
+                        WHEN builds.build_finished IS NULL THEN NULL
                         -- for finished builds we can show the full duration
                         ELSE (builds.build_finished - builds.build_started)
                     END
@@ -255,7 +256,7 @@ mod tests {
             let response = env
                 .web_app()
                 .await
-                .get("/crate/foo/0.1.0/builds")
+                .assert_success("/crate/foo/0.1.0/builds")
                 .await?
                 .error_for_status()?;
             response.assert_cache_control(CachePolicy::NoCaching, env.config());
@@ -268,8 +269,7 @@ mod tests {
                 .collect();
 
             assert_eq!(rows.len(), 1);
-            // third column contains build-start time, even when the rest is empty
-            assert_eq!(rows[0].chars().filter(|&c| c == '—').count(), 2);
+            assert_eq!(rows[0].chars().filter(|&c| c == '—').count(), 3);
 
             Ok(())
         });